Skip to content

Commit

Permalink
New tools/release/auto_release.pl script that automates most of relea…
Browse files Browse the repository at this point in the history 
…se process. Still needs MANIFEST update.
  • Loading branch information
@soh-cah-toa
soh-cah-toa committed Sep 20, 2011
1 parent ba4bd62 commit 8ee72e6
Showing 1 changed file with 494 additions and 0 deletions.
Loading

4 comments on commit 8ee72e6

@leto
Copy link
Member

@leto leto commented on 8ee72e6 Sep 22, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This script looks really useful.

@soh-cah-toa
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leto

Well, the line you're referring to is just make and not make test but I know what you mean. ;)

Even for the cases of test or fulltest, I don't think I need to make an explicit reference to $ENV{'TEST_JOBS'} since it'll automatically take effecti if it's defined. Perhaps you're suggesting something like:

if (defined $ENV{'TEST_JOBS'}) {
    system('make', 'test', $ENV{'TEST_JOBS'}) == 0 or stop();
}
else {
    system('make', 'test', 'TEST_JOBS=n') == 0 or stop();
}

If that's what you mean, then are you sure that's wise? Choosing a default value for $TEST_JOBS would be tricky as the appropriate value is highly dependant on the amount of resources available; varying from system to system.

Anyway, the -j5 switch just got leftover because that's what I normally use on my system. I fixed it in 56865e6.

@leto
Copy link
Member

@leto leto commented on 8ee72e6 Sep 22, 2011 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soh-cah-toa
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I took both your's and benabik's advice and added a --test-jobs switch in 169f00b and bfa7f50.

Please sign in to comment.