[GH# 828] Avoid passsing non-double through va_list

va_list does not support float, long double nor __float128 on most systems.
Promote FLOATVAL to double to avoid that.

src/pmc/float.pmc

@@ -139,9 +139,14 @@ Returns a Parrot string representation of the number.
 
     VTABLE STRING *get_repr() :no_wb {
         const FLOATVAL val      = SELF.get_number();
+#if NUMVAL_SIZE != 8
+        /* [GH #828] need to cast to double for varargs */
         const double d          = fabs((double)val);
         const char * const sign = val < 0 ? "-" : "";
-        return Parrot_sprintf_c(INTERP, "%s" FLOATVAL_FMT, sign, d);
+        return Parrot_sprintf_c(INTERP, "%s%.15g", sign, (double)val);
+#else
+        return Parrot_sprintf_c(INTERP, FLOATVAL_FMT, val);
+#endif
     }
 
 /*

t/src/embed/pmc.t

@@ -1,5 +1,5 @@
 #!perl
-# Copyright (C) 2010, Parrot Foundation.
+# Copyright (C) 2010-2012, Parrot Foundation.
 
 use strict;
 use warnings;
@@ -97,7 +97,7 @@ int main(int argc, char* argv[])
     Parrot_api_pmc_get_float(interpmc, p_float, &f_out);
 
     printf("%d\n", i_out);
-    printf("%.5f\n", f_out);
+    printf("%.5f\n", (double)f_out);
     return 0;
 }
 

t/src/extend_vtable.t

@@ -277,7 +277,7 @@ extend_vtable_output_is(<<'CODE', <<'OUTPUT', "Parrot_PMC_(set|get)_number_keyed
     string = createstring(interp,"foo");
     Parrot_PMC_set_number_keyed_str(interp, hash, string, 42.00);
     number = Parrot_PMC_get_number_keyed_str(interp, hash, string);
-    Parrot_printf(interp,"%.6f\n", number);
+    Parrot_printf(interp,"%.6f\n", (double)number);
 CODE
 42.000000
 Done!
@@ -436,7 +436,7 @@ extend_vtable_output_is(<<'CODE',<<'OUTPUT', "Parrot_PMC_i_modulus_float" );
     Parrot_PMC_set_number_native(interp, pmc,  50.0);
 
     Parrot_PMC_i_modulus_float(interp, pmc, 42.0);
-    Parrot_printf(interp, "%.2f\n",Parrot_PMC_get_number(interp, pmc));
+    Parrot_printf(interp, "%.2f\n",(double)Parrot_PMC_get_number(interp, pmc));
 CODE
 8.00
 Done!
@@ -686,7 +686,7 @@ OUTPUT
 extend_vtable_output_is(<<'CODE', <<'OUTPUT', "Parrot_PMC_(set|get)_number_keyed");
     Parrot_PMC_set_number_keyed(interp, rpa, key_int, 42.0);
     number = Parrot_PMC_get_number_keyed(interp, rpa, key_int);
-    Parrot_printf(interp,"%.02f\n", number);
+    Parrot_printf(interp,"%.02f\n", (double)number);
 CODE
 42.00
 Done!
@@ -695,7 +695,7 @@ OUTPUT
 extend_vtable_output_is(<<'CODE', <<'OUTPUT', "Parrot_PMC_(set|get)_number_keyed_int");
     Parrot_PMC_set_number_keyed_int(interp, rpa, 0, 42.0);
     number = Parrot_PMC_get_number_keyed_int(interp, rpa, 0);
-    Parrot_printf(interp,"%.02f\n", number);
+    Parrot_printf(interp,"%.02f\n", (double)number);
 CODE
 42.00
 Done!
@@ -810,10 +810,10 @@ OUTPUT
 extend_vtable_output_is(<<'CODE', <<'OUTPUT', "Parrot_PMC_(set|get)_number_keyed_int");
     number  = 42.0;
     number2 = 17.8;
-    Parrot_printf(interp,"%.2f\n", number2);
+    Parrot_printf(interp,"%.2f\n", (double)number2);
     Parrot_PMC_set_number_keyed_int(interp, rpa, 42, number);
     number2 = Parrot_PMC_get_number_keyed_int(interp, rpa, 42);
-    Parrot_printf(interp,"%.2f\n", number2);
+    Parrot_printf(interp,"%.2f\n", (double)number2);
 CODE
 17.80
 42.00
@@ -1021,7 +1021,7 @@ extend_vtable_output_is(<<'CODE', <<'OUTPUT', "Parrot_PMC_i_add_float" );
 
     Parrot_PMC_i_add_float(interp, pmc, number);
     number = Parrot_PMC_get_number(interp, pmc);
-    Parrot_printf(interp,"%.2f\n", number);
+    Parrot_printf(interp,"%.2f\n", (double)number);
 CODE
 1.00
 Done!
@@ -1132,7 +1132,7 @@ extend_vtable_output_is(<<'CODE', <<'OUTPUT', "Parrot_PMC_(push|pop)_float" );
     Parrot_PMC_push_float(interp, rpa, number);
     number2 = Parrot_PMC_pop_float(interp, rpa);
 
-    Parrot_printf(interp,"%.2f\n", number2);
+    Parrot_printf(interp,"%.2f\n", (double)number2);
 CODE
 42.00
 Done!
@@ -1145,7 +1145,7 @@ extend_vtable_output_is(<<'CODE', <<'OUTPUT', "Parrot_PMC_(unshift|shift)_float"
     Parrot_PMC_unshift_float(interp, rpa, number);
     number2 = Parrot_PMC_shift_float(interp, rpa);
 
-    Parrot_printf(interp,"%.2f\n", number2);
+    Parrot_printf(interp,"%.2f\n", (double)number2);
 CODE
 42.00
 Done!
@@ -1253,7 +1253,7 @@ extend_vtable_output_is(<<'CODE', <<'OUTPUT', "Parrot_PMC_i_floor_divide_float"
 
     Parrot_PMC_i_floor_divide_float(interp, pmc, number);
     number = Parrot_PMC_get_number(interp, pmc);
-    printf("%.2f\n", number);
+    printf("%.2f\n", (double)number);
 CODE
 2.00
 Done!
@@ -1266,7 +1266,7 @@ extend_vtable_output_is(<<'CODE', <<'OUTPUT', "Parrot_PMC_floor_divide_float" );
 
     pmc3 = Parrot_PMC_floor_divide_float(interp, pmc, number, pmc3);
     number = Parrot_PMC_get_number(interp, pmc3);
-    printf("%.2f\n", number);
+    printf("%.2f\n", (double)number);
 CODE
 2.00
 Done!
@@ -1372,7 +1372,7 @@ extend_vtable_output_is(<<'CODE', <<'OUTPUT', "Parrot_PMC_i_multiply_float" );
     */
     Parrot_PMC_i_multiply_float(interp, pmc, number);
     number = Parrot_PMC_get_integer(interp, pmc);
-    printf("%.2f\n", number);
+    printf("%.2f\n", (double)number);
 CODE
 42.00
 Done!
@@ -1390,7 +1390,7 @@ extend_vtable_output_is(<<'CODE', <<'OUTPUT', "Parrot_PMC_multiply_float" );
     */
     pmc3 = Parrot_PMC_multiply_float(interp, pmc, number, pmc3);
     number = Parrot_PMC_get_number(interp, pmc3);
-    printf("%.2f\n", number);
+    printf("%.2f\n", (double)number);
 CODE
 42.00
 Done!
@@ -1467,7 +1467,7 @@ extend_vtable_output_is(<<'CODE', <<'OUTPUT', "Parrot_PMC_i_divide_float" );
     number = 21.0;
     Parrot_PMC_i_divide_float(interp, pmc, number);
     number = Parrot_PMC_get_number(interp, pmc);
-    printf("%.2f\n", number);
+    printf("%.2f\n", (double)number);
 CODE
 2.00
 Done!
@@ -1479,7 +1479,7 @@ extend_vtable_output_is(<<'CODE', <<'OUTPUT', "Parrot_PMC_divide_float" );
     number = 21.0;
     pmc3 = Parrot_PMC_divide_float(interp, pmc, number, pmc3);
     number = Parrot_PMC_get_number(interp, pmc3);
-    printf("%.2f\n", number);
+    printf("%.2f\n", (double)number);
 CODE
 2.00
 Done!
@@ -1884,7 +1884,7 @@ extend_vtable_output_is(<<'CODE', <<'OUTPUT', "Parrot_PMC_add_float" );
 
     pmc3 = Parrot_PMC_add_float(interp, pmc, number, pmc3);
     number = Parrot_PMC_get_number(interp, pmc3);
-    printf("%.2f\n", number);
+    printf("%.2f\n", (double)number);
 CODE
 958.00
 Done!