Fix a bunch of compiler warnings

compilers/imcc/pbc.c

@@ -1621,7 +1621,7 @@ build_key(PARROT_INTERP, ARGIN(SymReg *key_reg))
 
     {
         STRING *name      = Parrot_key_set_to_string(interp, head);
-        const char *cname = Parrot_str_to_cstring(interp, name);
+        char *cname       = Parrot_str_to_cstring(interp, name);
         SymReg * const r  = _get_sym(&IMCC_INFO(interp)->globals->cs->key_consts, cname);
 
         if (r) {
@@ -1632,7 +1632,7 @@ build_key(PARROT_INTERP, ARGIN(SymReg *key_reg))
             store_key_const(interp, cname, k);
         }
 
-        Parrot_str_free_cstring((char *)cname);
+        Parrot_str_free_cstring(cname);
     }
 
     /* single 'S' keys already have their color assigned */

frontend/parrot/main.c

@@ -43,7 +43,11 @@ PARROT_PURE_FUNCTION
 static int is_all_hex_digits(ARGIN(const char *s))
         __attribute__nonnull__(1);
 
-static void Parrot_confess(char * condition, char * file, unsigned int line);
+static void Parrot_confess(
+    const char * condition,
+    const char * file,
+    unsigned int line);
+
 static void Parrot_version(void);
 PARROT_CAN_RETURN_NULL
 static const char * parseflags(
@@ -274,8 +278,8 @@ is_all_hex_digits(ARGIN(const char *s))
 
 /*
 
-=item C<static void Parrot_confess(char * condition, char * file, unsigned int
-line)>
+=item C<static void Parrot_confess(const char * condition, const char * file,
+unsigned int line)>
 
 Prints an error
 
@@ -284,7 +288,7 @@ Prints an error
 */
 
 static void
-Parrot_confess(char * condition, char * file, unsigned int line)
+Parrot_confess(const char * condition, const char * file, unsigned int line)
 {
     fprintf(stderr, "Parrot Error: %s (%s:%d)\n", condition, file, line);
 }

frontend/parrot_debugger/main.c

@@ -148,8 +148,8 @@ and C<debug_break> ops in F<ops/debug.ops>.
 
 static void PDB_printwelcome(void);
 static void PDB_run_code(PARROT_INTERP, int argc, const char *argv[]);
-const unsigned char * Parrot_get_config_hash_bytes();
-int Parrot_get_config_hash_length();
+const unsigned char * Parrot_get_config_hash_bytes(void);
+int Parrot_get_config_hash_length(void);
 
 /*
 

frontend/pbc_merge/main.c

@@ -282,7 +282,7 @@ pbc_merge_loadpbc(PARROT_INTERP, ARGIN(const char *fullname))
 
 static void
 ensure_libdep(PARROT_INTERP, PackFile_ByteCode *bc, STRING *lib) {
-    int i;
+    size_t i;
     for (i = 0; i < bc->n_libdeps; i++) {
         if (Parrot_str_equal(interp, bc->libdeps[i], lib)) {
             return;
@@ -315,7 +315,8 @@ pbc_merge_bytecode(PARROT_INTERP, ARGMOD(pbc_merge_input **inputs),
                    int num_inputs, ARGMOD(PackFile *pf))
 {
     ASSERT_ARGS(pbc_merge_bytecode)
-    int i, j;
+    int i;
+    size_t j;
     opcode_t *bc    = mem_gc_allocate_typed(interp, opcode_t);
     opcode_t cursor = 0;
 

src/library.c

@@ -350,11 +350,11 @@ get_search_paths(PARROT_INTERP, enum_lib_paths which)
     return VTABLE_get_pmc_keyed_int(interp, lib_paths, which);
 }
 
-static const char path_separator = '/';
+static const int path_separator = '/';
 
 #ifdef WIN32
 
-static const char win32_path_separator = '\\';
+static const int win32_path_separator = '\\';
 
 #endif
 
@@ -480,7 +480,7 @@ path_guarantee_trailing_separator(PARROT_INTERP, ARGMOD(STRING *path))
     ASSERT_ARGS(path_guarantee_trailing_separator)
 
     /* make sure the path has a trailing slash before appending the file */
-    if (STRING_ord(interp, path, -1) != path_separator)
+    if (STRING_ord(interp, path, -1) != (UINTVAL)path_separator)
         path = Parrot_str_concat(interp, path,
                 Parrot_str_chr(interp, path_separator));
 

src/nci/signatures.c

@@ -228,6 +228,8 @@ Parrot_nci_sig_to_pcc(PARROT_INTERP, ARGIN(PMC *sig_pmc), ARGOUT(STRING **params
             sig_buf[j++] = 'P';
             sig_buf[j++] = 's';
             break;
+          default:
+            break;
         }
     }
 

src/runcore/profiling.c

@@ -629,7 +629,7 @@ store_postop_time(PARROT_INTERP, ARGIN(Parrot_profiling_runcore_t *runcore))
 
     ASSERT_ARGS(store_postop_time)
 
-    if (interp->current_runloop_level-1 >= runcore->time_size) {
+    if (interp->current_runloop_level-1 >= (int)runcore->time_size) {
         runcore->time_size *= 2;
         runcore->time = mem_gc_realloc_n_typed(interp,
                 runcore->time, runcore->time_size + 1, UHUGEINTVAL);

tools/build/parrot_config_c.pl

@@ -45,8 +45,8 @@ =head1 DESCRIPTION
 #include "parrot/api.h"
 
 int Parrot_set_config_hash(Parrot_PMC interp_pmc);
-unsigned char * Parrot_get_config_hash_bytes();
-int Parrot_get_config_hash_length();
+const unsigned char * Parrot_get_config_hash_bytes(void);
+int Parrot_get_config_hash_length(void);
 
 static const unsigned char parrot_config[] = {
 EOF
@@ -81,14 +81,14 @@ =head1 DESCRIPTION
 print << "EOF";
 }; /* parrot_config */
 
-unsigned char*
-Parrot_get_config_hash_bytes()
+const unsigned char *
+Parrot_get_config_hash_bytes(void)
 {
-    return (unsigned char*)parrot_config;
+    return parrot_config;
 }
 
 int
-Parrot_get_config_hash_length()
+Parrot_get_config_hash_length(void)
 {
     return sizeof(parrot_config);
 }