Turn the strict-prototypes back to an error.

Include the ICU flags as -isystem instead of -I, so GCC knows to ignore warnings in ICU includes. not_gerd++ for showing the way, and benabik++ for being the guinea pig.
parrot · Mar 21, 2012 · a6b9346 · a6b9346
1 parent 9f73c7d
commit a6b9346
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/config/auto/icu.pm b/config/auto/icu.pm
@@ -388,14 +388,7 @@ sub _handle_ccflags_status {
     else {
         my $icuheaders = $arg->{icuheaders};
 
-        my $icuflags;
-        if ($icuheaders =~ /\s/) {
-            $icuflags = "-I \"$arg->{icuheaders}\"";
-        }
-        else {
-            $icuflags = "-I $arg->{icuheaders}";
-        }
-
+        my $icuflags = qq{-isystem "$icuheaders"};
         $conf->debug( "Adding $icuflags to ccflags for icu headers.\n");
         $conf->data->add( ' ', ccflags => $icuflags );
     }

diff --git a/config/auto/warnings.pm b/config/auto/warnings.pm
@@ -161,7 +161,7 @@ sub _init {
         -Wmissing-prototypes
         -Werror=nested-externs
         -Werror=old-style-definition
-        -Wstrict-prototypes
+        -Werror=strict-prototypes
     );
 
     $gcc->{'basic'} = [ @gcc_or_gpp_basic, @gcc_basic ];