Note that string_grow still has the problem with not bothering to all…

…ocate a new buffer if copysize is zero, e.g. if we are expanding a previously empty buffer. Courtesy of "Peter Gibbs" <peter@emkel.co.za> git-svn-id: https://svn.parrot.org/parrot/trunk@1340 d31e2699-5ff4-0310-a27c-f18f2fbe73fe
parrot · Apr 15, 2002 · b239e81 · b239e81
1 parent b2336dd
commit b239e81
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 10 deletions.
diff --git a/src/string.c b/src/string.c
@@ -72,11 +72,6 @@ string_make(struct Parrot_Interp *interpreter, const void *buffer,
  */
 STRING *
 string_grow(struct Parrot_Interp * interpreter, STRING * s, INTVAL addlen) {
-    INTVAL copysize = s->bufused;
-    if(addlen < 0)
-        copysize += addlen;
-    if(copysize <= 0)
-        return s;
     /* Don't check buflen, if we are here, we already checked. */
     Parrot_reallocate(interpreter, s, s->buflen + addlen);
     return s;

diff --git a/string.c b/string.c
@@ -72,11 +72,6 @@ string_make(struct Parrot_Interp *interpreter, const void *buffer,
  */
 STRING *
 string_grow(struct Parrot_Interp * interpreter, STRING * s, INTVAL addlen) {
-    INTVAL copysize = s->bufused;
-    if(addlen < 0)
-        copysize += addlen;
-    if(copysize <= 0)
-        return s;
     /* Don't check buflen, if we are here, we already checked. */
     Parrot_reallocate(interpreter, s, s->buflen + addlen);
     return s;