PATCH: Segfault on misspelled :outer

Courtesy of Bog Rogers <rogers-perl6@rgrjr.dyndns.org>

---
Workaround freeze/thaw depth first breakage, which kills
proper thawing of hashes, if these are contained in
outer data structures and aren't last in visit order.



git-svn-id: https://svn.parrot.org/parrot/trunk@10320 d31e2699-5ff4-0310-a27c-f18f2fbe73fe

classes/sub.pmc

@@ -439,10 +439,10 @@ Archives the subroutine.
         (info->visit_pmc_now)(INTERP, sub->namespace, info);
         info->thaw_ptr = &sub->multi_signature;
         (info->visit_pmc_now)(INTERP, sub->multi_signature, info);
-        info->thaw_ptr = &sub->lex_info;
-        (info->visit_pmc_now)(INTERP, sub->lex_info, info);
         info->thaw_ptr = &sub->outer_sub;
         (info->visit_pmc_now)(INTERP, sub->outer_sub, info);
+        info->thaw_ptr = &sub->lex_info;
+        (info->visit_pmc_now)(INTERP, sub->lex_info, info);
         SUPER(info);
     }
 

imcc/pbc.c

@@ -594,6 +594,10 @@ find_outer(Interp *interpreter, IMC_Unit *unit)
      * could be eval too - look, if :outer is the currentsub
      */
     current = CONTEXT(interpreter->ctx)->current_sub;
+    if (! current)
+        IMCC_fatal(interpreter, 1,
+                   "Undefined :outer sub '%s'.\n",
+                   unit->outer->name);
     cur_name = PMC_sub(current)->name;
     if (cur_name->strlen == len &&
             !memcmp((char*)cur_name->strstart, unit->outer->name, len)) {

t/op/lexicals.t

@@ -328,6 +328,16 @@ CODE
 ok
 OUTPUT
 
+pir_output_is(<<'CODE', <<'OUTPUT', ':outer parsing - missing :outer');
+.sub main
+    print "ok\n"
+.end
+.sub foo :outer(oops)
+.end
+CODE
+Undefined :outer sub 'oops'.
+OUTPUT
+
 pir_output_is(<<'CODE', <<'OUTPUT', 'get_lexinfo from pad');
 .sub main
     .lex '$a', P0
@@ -866,4 +876,4 @@ OUTPUT
 
 
 ## remember to change the number of tests :-)
-BEGIN { plan tests => 35; }
+BEGIN { plan tests => 36; }