Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unset debugging turned on by default #1099

Closed
rurban opened this issue Oct 14, 2014 · 3 comments
Closed

unset debugging turned on by default #1099

rurban opened this issue Oct 14, 2014 · 3 comments
Assignees
Milestone

Comments

@rurban
Copy link
Member

rurban commented Oct 14, 2014

set debugging in the configure hash when --debugging is given.
i.e. default to set $P0["debugging"], "0" in config hash.
-DNDEBUG is only set with --optimize to leave out assertions.

this is basically changing wrong t/configure/ tests which fail all over.
i.e. 001-options.t:75 for the feature check: ok
remove explicit checks for command-line option '--debugging' has been stored in object in all other tests.

@rurban rurban self-assigned this Oct 14, 2014
@rurban rurban added this to the 7.0.0 milestone Oct 14, 2014
rurban pushed a commit that referenced this issue Oct 14, 2014
allow --debugging=-g3
default: leave -g in CFLAGS but do set -DNDEBUG to leave out assertions.
set debugging in the configure hash only when --debugging is given.

This is basically changing wrong t/configure/ tests which were
copied&pasted all over to test for --debugging on by default all
over instead of just once.

See GH #1099
rurban pushed a commit that referenced this issue Oct 14, 2014
Add the missing width handling, and add tests.
for perl6 RT 116280, from Raku/roast@2647c16652
@rurban
Copy link
Member Author

rurban commented Oct 14, 2014

work is ready in branch rurban/debugging-off-gh1099

rurban pushed a commit that referenced this issue Oct 16, 2014
allow --debugging=-g3
default: leave -g in CFLAGS but do set -DNDEBUG to leave out assertions.
set debugging in the configure hash only when --debugging is given.

This is basically changing wrong t/configure/ tests which were
copied&pasted all over to test for --debugging on by default all
over instead of just once.

See GH #1099
@rurban
Copy link
Member Author

rurban commented Oct 16, 2014

rebased in smoke-me/debugging-off-gh1099 with 781dbba

@rurban rurban modified the milestones: 6.9.0, 7.0.0 Oct 17, 2014
@rurban
Copy link
Member Author

rurban commented Oct 17, 2014

Merged into 6.9.0

@rurban rurban closed this as completed Oct 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant