New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResizableFloatArray PMC does not have a test for sort method #927
Comments
Hi leto, there doesn't seem to be a sort() method in ResizableFloatArray. Should a method be added? Cheers, ptc |
On Sat, Mar 23, 2013 at 08:25:44AM -0700, ptc wrote:
Issue #925 claims that a sort() method was added to FixedFloatArray At any rate, I would expect any sort() method for ResizableFloatArray (FWIW, the only sort method that Rakudo currently makes use of Pm |
Looks like I thought I merged the ffa_sort branch, but I was mistaken. Just fixed that in d3bd99f With that, the RFA PMC should inherit the sort method, but I am not quite sure it will actually work. In any case, tests are very much appreciated. |
It's probably a good idea to check if sorting after an unshift works as well as the currently available tests for simply sorting and for sorting after a push. This way we test the interaction between resizing and sorting.
done |
Similar to #925
The text was updated successfully, but these errors were encountered: