Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResizableFloatArray PMC does not have a test for sort method #927

Closed
leto opened this issue Jan 15, 2013 · 4 comments
Closed

ResizableFloatArray PMC does not have a test for sort method #927

leto opened this issue Jan 15, 2013 · 4 comments

Comments

@leto
Copy link
Member

leto commented Jan 15, 2013

Similar to #925

@paultcochrane
Copy link
Contributor

Hi leto,

there doesn't seem to be a sort() method in ResizableFloatArray. Should a method be added?

Cheers,

ptc

@pmichaud
Copy link
Member

On Sat, Mar 23, 2013 at 08:25:44AM -0700, ptc wrote:

there doesn't seem to be a sort() method in ResizableFloatArray.
Should a method be added?

Issue #925 claims that a sort() method was added to FixedFloatArray
(which would be inherited by ResizableFloatArray),
but I can't find a sort method for either FixedFloatArray or
ResizableFloatArray in the master branch.

At any rate, I would expect any sort() method for ResizableFloatArray
to come from FixedFloatArray, in the same way that ResizablePMCArray
and ResizableIntegerArray inherit sort() from their "fixed" base classes.

(FWIW, the only sort method that Rakudo currently makes use of
is the one in ResizablePMCArray, which is inherited from
FixedPMCArray. And we'll be largely eliminating the use of
ResizablePMCArray for this soon.)

Pm

@leto
Copy link
Member Author

leto commented Mar 23, 2013

Looks like I thought I merged the ffa_sort branch, but I was mistaken. Just fixed that in d3bd99f

With that, the RFA PMC should inherit the sort method, but I am not quite sure it will actually work. In any case, tests are very much appreciated.

paultcochrane added a commit to paultcochrane/parrot that referenced this issue Mar 24, 2013
It's probably a good idea to check if sorting after an unshift works as well
as the currently available tests for simply sorting and for sorting after a
push.  This way we test the interaction between resizing and sorting.
@leto
Copy link
Member Author

leto commented Mar 25, 2013

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants