pass through args to cover #72
Conversation
|
This looks great. @parroty any chance this could be merged? |
|
@parroty just pinging again on this. I would love to have this merged. |
|
I'm sorry about leaving the PR open for long time. It seems I made this PR in conflict status due to the merge of other PR. |
|
Thanks @parroty. I'll get this updated today. |
like `—include remote`, but not including ExCoveralls specific args that cover won’t understand. fixes parroty#46
nathany
force-pushed
the
pass_through_args
branch
from
817cbe4
to
5585e04
Compare
| Mix.Tasks.Coveralls.do_run(args, | ||
| [ type: "local", | ||
| detail: true, | ||
| filter: parsed[:filter] || [] ]) |
There was a problem hiding this comment.
the filter arg was appearing twice after the other changes, so I removed this.
not sure if the default of [] is necessary? may need to find a way to bring it back?
There was a problem hiding this comment.
Not sure about that default either.
There was a problem hiding this comment.
Seems not necessary as it's checked at when used too.
| {common_options, _remaining, _invalid} = OptionParser.parse(args, switches: switches, aliases: aliases) | ||
|
|
||
| # the switches that excoveralls supports | ||
| supported_switches = Enum.map(Keyword.keys(switches), fn(s) -> "--#{s}" end) |
There was a problem hiding this comment.
equivalent to supported_switches = ~w(--filter --umbrella --verbose --pro --parallel -f -u -v) but this code adapts to new switches/aliases being added
|
@joshsmith @parroty Please take another look. The requirements changed when adding the |
| Mix.Tasks.Coveralls.do_run(args, | ||
| [ type: "local", | ||
| detail: true, | ||
| filter: parsed[:filter] || [] ]) |
There was a problem hiding this comment.
Not sure about that default either.
|
🙌 thanks @nathany! All good now. |
|
Thanks @nathany @joshsmith ! |
like
--include remote, but not including ExCoveralls specific args that cover won’t understand.fixes #46