Twitter sign in and authorization methods

[omnibs]

I've used the code created by @arjan referenced on Issue #14, adapted it to the extwitter structure and added some tests where things are testable.

As @arjan said, authorization is difficult to test with automation as it requires user interation on the twitter website, so I left the twitter access_token method commented in the tests.

This is my first Elixir PR so I may have made something silly in the few lines of code that were my own. As so I'm open to any suggestions, code or commit cleanups, etc.

I'm also OK with the idea that authorization/authentication/access token logistics could be better off in a separate module in another repo. It's plausible that people doing just twitter sign-in don't necessarily want to add a complete twitter API to their projects.

Oh yeah, I also updated mix.lock to make it build on ERL 18.

[omnibs]

Missed the vcr fixture for the request_token test, but the rate limit exceed test is still failing.

Exvcr is not detecting the custom cassette for https://api.twitter.com/1.1/followers/ids.json. A bug in exvcr maybe?

Also, cool thing these custom cassettes, I can use one to make the access_token method testable :)

[omnibs]

Alright, it seems exvcr's custom: true flag makes fixtures strict about query string matching.

I thought that might be a bug, so I updated the dependencies.

Turned out it wasn't, so I made the custom fixture take regex urls and fixed it.

All tests are passing but hackney is blowing up for some reason. Could it be the updated dependencies? Will investigate further (help or input is welcome).

[omnibs]

Yay, all tests passing =]

Looks like there was a problem with SSL and 17.3, something in the coveralls script was blowing up due to that. Thank goodness there was a clue in hackney's README.md.

[parroty]

The following APIs corresponds to the newly added methods (correct?) If so, can we have them as "Reference" too?
https://dev.twitter.com/oauth/reference/post/oauth/request_token
https://dev.twitter.com/oauth/reference/post/oauth/access_token
https://dev.twitter.com/oauth/reference/get/oauth/authorize
https://dev.twitter.com/oauth/reference/get/oauth/authenticate

[parroty]

Thanks for the PR! I put some comments in the code, I appreciate if you could check.

I'm thinking it's good to have example sequence in somewhere (readme or wiki). I could confirm the minimal behavior in the following, but if you have other example sequence (ex. callback case), I appreciate if you could share them!

token = ExTwitter.request_token()

{:ok, authorize_url} = ExTwitter.authorize_url(token.oauth_token)

IO.puts authorize_url
# Open browser and authorize to retrieve verifier (pincode)
pincode = "999999"

access_token = ExTwitter.access_token(pincode, token.oauth_token)

Extwitter.configure(
  consumer_key: System.get_env("TWITTER_CONSUMER_KEY"),
  consumer_secret: System.get_env("TWITTER_CONSUMER_SECRET"),
  access_token: access_token.oauth_token,
  access_token_secret: access_token.oauth_token_secret
)

ExTwitter.user_timeline

[omnibs]

Hey parroty, check out the changes.

Tuples, maps and structs were still kinda weird for me when I did this. Thanks for pointing out that specs thing =]

Any more comments?

[parroty]

Thanks for the extensive work!