Exclude :stub mode from applying match_requests_on: [:request_body] by default

[nsi88]

Hi @parroty! Looks like it's impossible to disable check for request_body in stub mode.
Maybe just disable it by default?

[coveralls]

Coverage remained the same at 93.285% when pulling 36970db on nsi88:request_body_and_stub into be14d4e on parroty:master.

[parroty]

Thanks for the PR. Some of the tests are failing for this change. If it's about making the request_body parameter optional, the conditions like following match with your expectation?

if (stub_mode?(recorder_options) && keys[:request_body] != nil) || has_match_requests_on(:request_body, recorder_options) do

Also, it would be great to have test new condition too 😃 .

[nsi88]

Yes. I think the condition will work for me. Will finish the PR when
will find time

05/06/16 21:41, parroty пишет:

Thanks for the PR. Some of the tests are failing for this change. If
it's about making the |request_body| parameter optional, the
conditions like following match with your expectation?

if (stub_mode?(recorder_options)&& keys[:request_body]!= nil)|| has_match_requests_on(:request_body, recorder_options)do

Also, it would be great to have test new condition too 😃 .

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#61 (comment), or
mute the thread
https://github.com/notifications/unsubscribe/ADyCOQpTG9P7vL6SV6y_5Kj3lOtqmmFhks5qIuAjgaJpZM4IniuQ.

Best regards
Sergey Novikov

[parroty]

I assume this item is covered by #89 and closing at the moment.
If you find remaining issue, please reopen or open another one.