New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated maintainers in Dockerfiles #126
Conversation
@@ -1,5 +1,5 @@ | |||
FROM ubuntu:14.04 | |||
MAINTAINER Nooshin Mirzadeh <nooshin.mirzadeh@epfl.ch> | |||
MAINTAINER Mark Sutherland <mark.sutherland@epfl.ch> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MAINTAINER directive has been deprecated. It has to be replaced by a LABLE like this:
LABEL maintainer="mark.sutherland@epfl.ch"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -1,5 +1,5 @@ | |||
FROM ubuntu:14.04 | |||
MAINTAINER Nooshin Mirzadeh <nooshin.mirzadeh@epfl.ch> | |||
MAINTAINER Arash Pourhabibi <arash.pourhabibi@epfl.ch> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe Mark should be the maintainer of web-serving (all the tiers).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have this in a local commit which I can merge (all of the updated Dockerfiles have my email as well as the LABEL tag)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neo-apz done, please check
@@ -1,5 +1,5 @@ | |||
FROM cloudsuite/java | |||
MAINTAINER Javier Picorel <javier.picorel@epfl.ch> | |||
MAINTAINER Sidharth Gupta <sidharth.gupta@epfl.ch> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to fix this one.
Same for the client image of web-search.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, good catch, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot the client. 🤦♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, now it's fine
ok, now done 😅 |
Update maintainers in Dockerfiles (parsa-epfl#126)
No description provided.