Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated maintainers in Dockerfiles #126

Merged
merged 10 commits into from Apr 4, 2018
Merged

updated maintainers in Dockerfiles #126

merged 10 commits into from Apr 4, 2018

Conversation

ustiugov
Copy link
Contributor

@ustiugov ustiugov commented Apr 4, 2018

No description provided.

@ustiugov ustiugov requested a review from neo-apz April 4, 2018 10:46
@@ -1,5 +1,5 @@
FROM ubuntu:14.04
MAINTAINER Nooshin Mirzadeh <nooshin.mirzadeh@epfl.ch>
MAINTAINER Mark Sutherland <mark.sutherland@epfl.ch>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MAINTAINER directive has been deprecated. It has to be replaced by a LABLE like this:

LABEL maintainer="mark.sutherland@epfl.ch"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -1,5 +1,5 @@
FROM ubuntu:14.04
MAINTAINER Nooshin Mirzadeh <nooshin.mirzadeh@epfl.ch>
MAINTAINER Arash Pourhabibi <arash.pourhabibi@epfl.ch>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Mark should be the maintainer of web-serving (all the tiers).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have this in a local commit which I can merge (all of the updated Dockerfiles have my email as well as the LABEL tag)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neo-apz done, please check

@@ -1,5 +1,5 @@
FROM cloudsuite/java
MAINTAINER Javier Picorel <javier.picorel@epfl.ch>
MAINTAINER Sidharth Gupta <sidharth.gupta@epfl.ch>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to fix this one.
Same for the client image of web-search.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, good catch, thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot the client. 🤦‍♂️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, now it's fine

@ustiugov
Copy link
Contributor Author

ustiugov commented Apr 4, 2018

ok, now done 😅

@neo-apz neo-apz merged commit 0eb75ed into master Apr 4, 2018
@ustiugov ustiugov deleted the corrections_and_updates branch April 4, 2018 12:35
saimadanmohan added a commit to saimadanmohan/cloudsuite that referenced this pull request Apr 26, 2018
Update maintainers in Dockerfiles (parsa-epfl#126)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants