Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add lock file to repository #750

Closed
wants to merge 5 commits into from

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented May 21, 2022

New Pull Request Checklist

Issue Description

Related issue: #749

Approach

  • Remove pubspec.lock from .gitignore so that it is checked in to this repository for development.
  • Add pubspec.lock to .pubignore so that it is not published in the registry as part of the package.

TODOs before merging

n/a

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza mtrezza linked an issue May 21, 2022 that may be closed by this pull request
3 tasks
@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #750 (c749701) into master (d80ca58) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #750   +/-   ##
=======================================
  Coverage   10.28%   10.28%           
=======================================
  Files          48       48           
  Lines        2810     2810           
=======================================
  Hits          289      289           
  Misses       2521     2521           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d80ca58...c749701. Read the comment docs.

Copy link
Contributor

@fischerscode fischerscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fischerscode
Copy link
Contributor

The failing test is fixed as part of #734.

@mtrezza mtrezza closed this Feb 26, 2023
@mtrezza mtrezza deleted the ci-add-lock-file branch February 26, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pubspec.lock to repository
2 participants