New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Attributes reverse
, padding
, physics
, controller
, scrollDirection
, shrinkWrap
not implemented in ParseLiveGridWidget
#761
Conversation
Scroll Direction and other parameters/attributes
Thanks for opening this pull request!
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #761 +/- ##
==========================================
- Coverage 39.11% 39.04% -0.08%
==========================================
Files 57 57
Lines 3280 3286 +6
==========================================
Hits 1283 1283
- Misses 1997 2003 +6
☔ View full report in Codecov by Sentry. |
Is this a bug fix or a feature extension? |
It's a mix, I guess. Maybe more of a bug fix, since the parameters already exist and are just not used (bug). |
Does this PR require any tests or doc changes? @pastordee could you please go through the TODOs at the top? |
ParseLiveGridWidget
not used
ParseLiveGridWidget
not usedParseLiveGridWidget
are not used
sorry guys is a bug fix some of the parameters are not used |
no it doesn't need a test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add an entry to the flutter changelog?
Since we don't know with which version this PR will be released, you can add this to the top of the changelog:
# Unreleased
### Bug Fixes
* some parameters of `ParseLiveGridWidget` are not used ([#761](https://github.com/parse-community/Parse-SDK-Flutter/pull/761))
no it doesn't need a test
Code coverage reports that the added lines are not covered by tests, so they will decrease coverage. Could you add tests or maybe just expand existing tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the already existing parameters are only forwarded to the Flutter widget, I don't see what could go wrong with this.
Comment regarding the missing tests:
I think we can merge this without adding tests, since we currently have no tests regarding widgets and in my opinion this PR doe not make the bad situation worse. (Of course I don't think we shouldn't add tests for this parameters when adding tests for the ParseLiveWidgets.)*
If it takes too much research to add tests for this since we don't test widgets yet at all, then we can merge just to fix the bug. But we will at some point begin to make tests a requirement for merging a PR. Otherwise - by experience - these tests are unlikely to be added in the future and coverage will continue to decrease. @fischerscode You already approved this PR, but note that it's missing a changelog entry, that is a hard requirement for PRs already. |
Sorry, thought we want to create it automatically for the next release. |
I wish! But I think it will take some time to add auto-release to this mono repo. |
added to the change log |
packages/flutter/example/linux/flutter/generated_plugin_registrant.h
Outdated
Show resolved
Hide resolved
Hi can we approve and merge this please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR will be released as flutter version 3.1.4; to merge this, the flutter package version needs to be updated as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtrezza
Which parts need to be changed?
Done |
@pastordee
|
Sorted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog entry
@pastordee I think you should bump the version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect changelog entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just the package version needs to be bumped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good
New Pull Request Checklist
Issue Description
Implementation of Scroll Direction and other other parameters/attributes
Related issue: #760
Approach
TODOs before merging
n/a