Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Attributes reverse, padding, physics, controller, scrollDirection, shrinkWrap not implemented in ParseLiveGridWidget #761

Merged
merged 37 commits into from
May 20, 2023
Merged
Show file tree
Hide file tree
Changes from 35 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
d363859
Update parse_live_grid.dart
pastordee Jun 2, 2022
57a5ab6
Update parse_live_grid.dart
pastordee Jun 2, 2022
847b825
Added to change log
pastordee Jun 3, 2022
b0f4178
Merge branch 'master' into master
mtrezza Oct 5, 2022
166c961
Update packages/flutter/CHANGELOG.md
mtrezza Oct 5, 2022
a8bf436
Merge branch 'master' into master
mtrezza Dec 21, 2022
e2146e7
Merge remote-tracking branch 'upstream/master'
pastordee Mar 2, 2023
dcc11e4
Update CHANGELOG.md
pastordee Mar 2, 2023
5ff358c
Update pubspec.yaml
pastordee Mar 2, 2023
2a150a8
Update packages/flutter/pubspec.yaml
mtrezza Mar 2, 2023
e9fcdf1
Update packages/flutter/CHANGELOG.md
mtrezza Mar 2, 2023
c6b637a
Merge branch 'master' into master
mtrezza Mar 2, 2023
b2652be
Merge remote-tracking branch 'upstream/master'
pastordee Mar 8, 2023
ebe9744
Merge branch 'master' of https://github.com/pastordee/Parse-SDK-Flutter
pastordee Mar 8, 2023
2382821
Update pubspec.yaml
pastordee Mar 8, 2023
3f76f67
Merge remote-tracking branch 'upstream/master'
pastordee Mar 20, 2023
a4efdee
Update parse_live_grid.dart
pastordee Mar 20, 2023
a650970
Update parse_live_grid.dart
pastordee Mar 20, 2023
37fd1b3
Merge branch 'master' into master
mtrezza Mar 20, 2023
2336a2a
Update CHANGELOG.md
pastordee Mar 21, 2023
b9fd08f
Merge branch 'master' of https://github.com/pastordee/Parse-SDK-Flutter
pastordee Mar 21, 2023
9876726
Merge remote-tracking branch 'upstream/master'
pastordee May 14, 2023
8ac7882
Update parse_live_list.dart
pastordee May 14, 2023
f86e8d1
Update CHANGELOG.md
pastordee May 14, 2023
afb01c0
Update CHANGELOG.md
pastordee May 14, 2023
dcf6d7d
Update CHANGELOG.md
pastordee May 14, 2023
9f48286
Update parse_live_list.dart
pastordee May 14, 2023
91c9de4
Update CHANGELOG.md
pastordee May 14, 2023
d75eed9
Merge remote-tracking branch 'upstream/master'
pastordee May 16, 2023
2b2a099
Merge branch 'master' into master
mtrezza May 17, 2023
80229af
Merge remote-tracking branch 'upstream/master'
pastordee May 18, 2023
8d52e9d
Merge branch 'master' of https://github.com/pastordee/Parse-SDK-Flutter
pastordee May 18, 2023
5d16bb6
Added changelog entry
pastordee May 18, 2023
26a49bb
fix changelog entry
mtrezza May 20, 2023
d376479
remove empty line
mtrezza May 20, 2023
7f00edb
bump package version
mtrezza May 20, 2023
85dc209
Merge branch 'master' into master
mtrezza May 20, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/flutter/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## [5.0.1](https://github.com/parse-community/Parse-SDK-Flutter/compare/flutter-5.0.0...flutter-5.0.1) (2023-05-20)

### Bug Fixes

* Attributes `reverse`, `padding`, `physics`, `controller`, `scrollDirection`, `shrinkWrap` not implemented in `ParseLiveGridWidget` ([#761](https://github.com/parse-community/Parse-SDK-Flutter/pull/761))

## [5.0.0](https://github.com/parse-community/Parse-SDK-Flutter/compare/flutter-4.0.0...flutter-5.0.0) (2023-05-14)

### BREAKING CHANGES
Expand Down
1 change: 1 addition & 0 deletions packages/flutter/example/ios/Flutter/Debug.xcconfig
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
#include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig"
#include "Generated.xcconfig"
1 change: 1 addition & 0 deletions packages/flutter/example/ios/Flutter/Release.xcconfig
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
#include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.release.xcconfig"
#include "Generated.xcconfig"
44 changes: 44 additions & 0 deletions packages/flutter/example/ios/Podfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
# Uncomment this line to define a global platform for your project
# platform :ios, '11.0'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'

project 'Runner', {
'Debug' => :debug,
'Profile' => :release,
'Release' => :release,
}

def flutter_root
generated_xcode_build_settings_path = File.expand_path(File.join('..', 'Flutter', 'Generated.xcconfig'), __FILE__)
unless File.exist?(generated_xcode_build_settings_path)
raise "#{generated_xcode_build_settings_path} must exist. If you're running pod install manually, make sure flutter pub get is executed first"
end

File.foreach(generated_xcode_build_settings_path) do |line|
matches = line.match(/FLUTTER_ROOT\=(.*)/)
return matches[1].strip if matches
end
raise "FLUTTER_ROOT not found in #{generated_xcode_build_settings_path}. Try deleting Generated.xcconfig, then run flutter pub get"
end

require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root)

flutter_ios_podfile_setup

target 'Runner' do
use_frameworks!
use_modular_headers!

flutter_install_all_ios_pods File.dirname(File.realpath(__FILE__))
target 'RunnerTests' do
inherit! :search_paths
end
end

post_install do |installer|
installer.pods_project.targets.each do |target|
flutter_additional_ios_build_settings(target)
end
end
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
#include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig"
#include "ephemeral/Flutter-Generated.xcconfig"
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
#include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.release.xcconfig"
#include "ephemeral/Flutter-Generated.xcconfig"
43 changes: 43 additions & 0 deletions packages/flutter/example/macos/Podfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
platform :osx, '10.14'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'

project 'Runner', {
'Debug' => :debug,
'Profile' => :release,
'Release' => :release,
}

def flutter_root
generated_xcode_build_settings_path = File.expand_path(File.join('..', 'Flutter', 'ephemeral', 'Flutter-Generated.xcconfig'), __FILE__)
unless File.exist?(generated_xcode_build_settings_path)
raise "#{generated_xcode_build_settings_path} must exist. If you're running pod install manually, make sure \"flutter pub get\" is executed first"
end

File.foreach(generated_xcode_build_settings_path) do |line|
matches = line.match(/FLUTTER_ROOT\=(.*)/)
return matches[1].strip if matches
end
raise "FLUTTER_ROOT not found in #{generated_xcode_build_settings_path}. Try deleting Flutter-Generated.xcconfig, then run \"flutter pub get\""
end

require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root)

flutter_macos_podfile_setup

target 'Runner' do
use_frameworks!
use_modular_headers!

flutter_install_all_macos_pods File.dirname(File.realpath(__FILE__))
target 'RunnerTests' do
inherit! :search_paths
end
end

post_install do |installer|
installer.pods_project.targets.each do |target|
flutter_additional_macos_build_settings(target)
end
end
6 changes: 6 additions & 0 deletions packages/flutter/lib/src/utils/parse_live_grid.dart
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,12 @@
),
);
return GridView.builder(
reverse: widget.reverse,
padding: widget.padding,
physics: widget.scrollPhysics,
controller: widget.scrollController,
scrollDirection: widget.scrollDirection,
shrinkWrap: widget.shrinkWrap,

Check warning on line 159 in packages/flutter/lib/src/utils/parse_live_grid.dart

View check run for this annotation

Codecov / codecov/patch

packages/flutter/lib/src/utils/parse_live_grid.dart#L154-L159

Added lines #L154 - L159 were not covered by tests
itemCount: liveGrid.size,
gridDelegate: SliverGridDelegateWithFixedCrossAxisCount(
crossAxisCount: widget.crossAxisCount,
Expand Down