Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Push notifications in iOS not working #940

Merged
merged 13 commits into from Jun 28, 2023
Merged

fix: Push notifications in iOS not working #940

merged 13 commits into from Jun 28, 2023

Conversation

mbfakourii
Copy link
Member

Pull Request

Issue

Changing awesome_notifications package to flutter_local_notifications in ParseNotification

Closes: #936

Approach

n/a

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.16 ⚠️

Comparison is base (bae8902) 39.50% compared to head (de31fe0) 39.34%.

❗ Current head de31fe0 differs from pull request most recent head 052f7a1. Consider uploading reports for the commit 052f7a1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #940      +/-   ##
==========================================
- Coverage   39.50%   39.34%   -0.16%     
==========================================
  Files          60       60              
  Lines        3339     3355      +16     
==========================================
+ Hits         1319     1320       +1     
- Misses       2020     2035      +15     
Impacted Files Coverage Δ
packages/flutter/lib/parse_server_sdk_flutter.dart 20.00% <ø> (ø)
...utter/lib/src/notification/parse_notification.dart 0.00% <0.00%> (ø)
packages/flutter/lib/src/push/parse_push.dart 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mbfakourii mbfakourii requested a review from a team June 21, 2023 09:51
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires clarification of license #936 (comment)

@mbfakourii
Copy link
Member Author

@mtrezza
Ready to merge?

@mtrezza
Copy link
Member

mtrezza commented Jun 28, 2023

Is this package change in any way a breaking change for developers, or is that only internally?

@mbfakourii
Copy link
Member Author

mbfakourii commented Jun 28, 2023

Is this package change in any way a breaking change for developers, or is that only internally?

No, it is not a breaking change, only internally

@mtrezza
Copy link
Member

mtrezza commented Jun 28, 2023

Got it; since this is a bug fix, could you change the PR title to describe the bug?

@mbfakourii mbfakourii changed the title fix: Changing awesome_notifications package to flutter_local_notifications in ParseNotification fix: change base notification in ParseNotification for bug in ios Jun 28, 2023
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: change base notification in ParseNotification for bug in ios fix: Change base notification in ParseNotification for bug in ios Jun 28, 2023
@mtrezza mtrezza changed the title fix: Change base notification in ParseNotification for bug in ios fix: Push notification in iOS not working Jun 28, 2023
packages/flutter/CHANGELOG.md Outdated Show resolved Hide resolved
@mtrezza mtrezza merged commit ac682f2 into parse-community:master Jun 28, 2023
13 checks passed
@mtrezza mtrezza changed the title fix: Push notification in iOS not working fix: Push notifications in iOS not working Jun 28, 2023
@mbfakourii mbfakourii deleted the remove_awesome_notifications_and_replace_with_flutter_local_notifications branch October 3, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

awesome_notifications causing problems with iOS
2 participants