Fix: Live Query Subscription Open Event #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #1147 Waits 200 milliseconds to allow for client to set open event after the subscription resolves.
|
@dplewis I've just noticed the tests are not passing. Could you please take a look? |
Codecov Report
@@ Coverage Diff @@
## master #1151 +/- ##
=======================================
Coverage 92.21% 92.21%
=======================================
Files 54 54
Lines 5268 5268
Branches 1178 1178
=======================================
Hits 4858 4858
Misses 410 410
Continue to review full report at Codecov.
|
dplewis
added a commit
that referenced
this pull request
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1147
Waits 200 milliseconds to allow for client to set open event after the subscription resolves.