Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Live Query Subscription Error Event #1193

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 15, 2020

Similar to #1151

Waits 200 milliseconds to allow for client to set error event after the subscription resolves.

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #1193 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1193   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files          54       54           
  Lines        5294     5294           
  Branches     1191     1191           
=======================================
  Hits         4889     4889           
  Misses        405      405           
Impacted Files Coverage Δ
src/LiveQueryClient.js 87.76% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75c0095...25ec4c3. Read the comment docs.

@dplewis dplewis merged commit 5a231f2 into master Jul 16, 2020
@dplewis dplewis deleted the fix-subscription-error branch July 16, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant