Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Duplicate pending operations on nested fields #2162

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jun 6, 2024

Pull Request

Issue

#1453 Introduced a bug that effected all fields not just nested fields. This results in breaking cloud code and prevents the latest SDK version from merging with the server.

Closes: parse-community/parse-server#9131

Approach

Revert changes in #1453 and properly handle pending operations on nested fields only as the are handled by get attributes.

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

Thanks for opening this pull request!

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (210f8d6) to head (095fdfe).

Additional details and impacted files
@@            Coverage Diff            @@
##             alpha     #2162   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         6360      6364    +4     
  Branches      1534      1510   -24     
=========================================
+ Hits          6360      6364    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis requested a review from a team June 6, 2024 17:58
@mtrezza mtrezza merged commit df6df7c into parse-community:alpha Jun 7, 2024
11 checks passed
parseplatformorg pushed a commit that referenced this pull request Jun 7, 2024
# [5.2.0-alpha.2](5.2.0-alpha.1...5.2.0-alpha.2) (2024-06-07)

### Bug Fixes

* Duplicate pending operations on nested fields ([#2162](#2162)) ([df6df7c](df6df7c))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 7, 2024
@dplewis dplewis deleted the revert-1453 branch June 8, 2024 10:40
parseplatformorg pushed a commit that referenced this pull request Jun 24, 2024
# [5.2.0-beta.1](5.1.0...5.2.0-beta.1) (2024-06-24)

### Bug Fixes

* `LiveQueryClient.resubscribe` with Parse Server 7 causes many open connections ([#2184](#2184)) ([71b4d17](71b4d17))
* `Parse.Installation` not working when installation is deleted on server ([#2126](#2126)) ([22360b4](22360b4))
* Duplicate pending operations on nested fields ([#2162](#2162)) ([df6df7c](df6df7c))

### Features

* Support dot notation on array fields ([#2120](#2120)) ([25ec684](25ec684))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 24, 2024
parseplatformorg pushed a commit that referenced this pull request Jun 29, 2024
# [5.2.0](5.1.0...5.2.0) (2024-06-29)

### Bug Fixes

* `LiveQueryClient.resubscribe` with Parse Server 7 causes many open connections ([#2184](#2184)) ([71b4d17](71b4d17))
* `Parse.Installation` not working when installation is deleted on server ([#2126](#2126)) ([22360b4](22360b4))
* Dot notation on JSON arrays doesn't work on `PushStatus` offset fields ([#2194](#2194)) ([e0eb6f0](e0eb6f0))
* Duplicate pending operations on nested fields ([#2162](#2162)) ([df6df7c](df6df7c))

### Features

* Support dot notation on array fields ([#2120](#2120)) ([25ec684](25ec684))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Parse 5.1.0 fails
3 participants