Made all methods in ReflectionHelpers non-extensions. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: as we start adding support for more platforms which may or may not have this natively, our extension methods are not guaranteed to be invoked if they have the same name of a builtin method. My requiring explicit invoking, it allows us to enforce custom logic here. Fixes #111 (for real this time).
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| namespace Parse.Internal { | |||
| static class ReflectionHelpers { | |||
There was a problem hiding this comment.
Hmm. So this is because of GetConstructors shouldn't be used as extension, right?
If it is, can you add some description here on why is this not an extension for future reference?
|
Looking good. Should've known that magic don't last forever :( |
|
Good night, sweet extension prince :( |
richardjrossiii
added a commit
that referenced
this pull request
Dec 10, 2015
…ds.disable Made all methods in ReflectionHelpers non-extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: as we start adding support for more platforms which may or may not have this natively, our extension methods are not guaranteed to be invoked if they have the same name of a builtin method.
My requiring explicit invoking, it allows us to enforce custom logic here.
Fixes #111 (for real this time).