Drop support for Unity 4, to support push notifications. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Push notifications on Unity 5 were broken due to IL2CPP not supporting PropertyInfo being exported by any type. Fixes #36.
| @@ -1023,36 +1023,15 @@ private class SettingsWrapper : IDictionary<string, object> { | |||
| /// </summary> | |||
| /// <param name="action">Action to be completed when device token is received.</param> | |||
| internal static void RegisterDeviceTokenRequest(Action<byte[]> action) { | |||
| // Basically what we want to achieve here is: | |||
There was a problem hiding this comment.
I'm glad I left this comment
|
This looks good to me. Let's punt this to |
|
Hmm. Seeing as these methods are currently broken in the 1.6 release, do we really want to keep them broken (for both unity 4 and 5) in the next release? |
|
You're correct. Let's land this then |
|
Merge this maybe? |
|
My bad, PR wasn't assigned to me so I didn't see it :) |
richardjrossiii
added a commit
that referenced
this pull request
Oct 29, 2015
Drop support for Unity 4, to support push notifications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push notifications on Unity 5 were broken due to IL2CPP not supporting PropertyInfo being exported by any type.
Fixes #36.