New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated releases #1219
Automated releases #1219
Conversation
flovilmart
commented
Dec 4, 2017
•
edited
edited
- Adds automated Github releases upload on tags
- Adds automated Cocoapods releases on tags
- Adds automated docs generation through Jazzy on master merges (gh-pages force push)
- Revamps Travis.yaml to leverage build stages
- Generated docs demo available here: http://flovilmart.github.io/Parse-SDK-iOS-OSX/api/
Next on the bucket list
|
Seems the release stage is hanging the CI? |
It’s just taking forever as Travis only allows 2 concurrent Mac based builds now :/ |
Sorry for the zillion commits :) it gives a sense of how s****y it is to configure it :) |
@montymxb just finished :) |
.travis.yml
Outdated
branches: | ||
only: | ||
- master | ||
- /^v?[0-9]+.[0-9]+.[0-9]+(-.*)?$/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're going to want to escape those .
s. In a regex it's interpreted as a special 'match any' character unless it's escaped by a preceding \
. This regex could match stuff like 123
or 1a2b3c
in addition to v1.2.3
. The exception being if it's in a character class, such as [.]
, where it's interpreted just as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uhm that's a good point! I need to update it all over the place then :)
@@ -65,6 +65,18 @@ Notice the API docs aren't totally up to date when it comes to latest Swift sign | |||
|
|||
We want to make contributing to this project as easy and transparent as possible. Please refer to the [Contribution Guidelines][contributing]. | |||
|
|||
## Preparing for a new release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we want this in the README. Although it is helpful for us it's not something we necessarily need to show to users. This might be more appropritae in CONTRIBUTING I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, many project have it in the README, it's worth having in case you forget in any case, those are part of the scripts. The bumping just changes the versions all over the required files, nothing dangerous in there. I'd keep it there. (https://github.com/danger/danger-js#releasing-a-new-version-of-danger)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, fair enough. That does make sense if we want new individuals (or existing) to be able to follow a standard for releasing a new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found myself multiple times wondering how to bump the version number :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good