Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated releases #1219

Merged
merged 29 commits into from Dec 5, 2017
Merged

Automated releases #1219

merged 29 commits into from Dec 5, 2017

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented Dec 4, 2017

  • Adds automated Github releases upload on tags
  • Adds automated Cocoapods releases on tags
  • Adds automated docs generation through Jazzy on master merges (gh-pages force push)
  • Revamps Travis.yaml to leverage build stages
  • Generated docs demo available here: http://flovilmart.github.io/Parse-SDK-iOS-OSX/api/

@flovilmart
Copy link
Contributor Author

Next on the bucket list

  • Release docs for all other projects in their own GH-pages (stop aggregating everything)
  • Update the docs.parseplatform.org / readmes to point to specific repos's docs (which makes more sense and easier to maintain)

@montymxb
Copy link

montymxb commented Dec 4, 2017

Seems the release stage is hanging the CI?

@flovilmart
Copy link
Contributor Author

It’s just taking forever as Travis only allows 2 concurrent Mac based builds now :/

@flovilmart
Copy link
Contributor Author

Sorry for the zillion commits :) it gives a sense of how s****y it is to configure it :)

@flovilmart
Copy link
Contributor Author

@montymxb just finished :)

.travis.yml Outdated
branches:
only:
- master
- /^v?[0-9]+.[0-9]+.[0-9]+(-.*)?$/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're going to want to escape those .s. In a regex it's interpreted as a special 'match any' character unless it's escaped by a preceding \. This regex could match stuff like 123 or 1a2b3c in addition to v1.2.3. The exception being if it's in a character class, such as [.], where it's interpreted just as it is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhm that's a good point! I need to update it all over the place then :)

@@ -65,6 +65,18 @@ Notice the API docs aren't totally up to date when it comes to latest Swift sign

We want to make contributing to this project as easy and transparent as possible. Please refer to the [Contribution Guidelines][contributing].

## Preparing for a new release
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we want this in the README. Although it is helpful for us it's not something we necessarily need to show to users. This might be more appropritae in CONTRIBUTING I think.

Copy link
Contributor Author

@flovilmart flovilmart Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, many project have it in the README, it's worth having in case you forget in any case, those are part of the scripts. The bumping just changes the versions all over the required files, nothing dangerous in there. I'd keep it there. (https://github.com/danger/danger-js#releasing-a-new-version-of-danger)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, fair enough. That does make sense if we want new individuals (or existing) to be able to follow a standard for releasing a new version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found myself multiple times wondering how to bump the version number :)

Copy link

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good :octocat:

@flovilmart flovilmart merged commit 0469af6 into master Dec 5, 2017
@flovilmart flovilmart deleted the automated-releases branch December 5, 2017 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants