Updated FBSDK to 9.0 #1599
Merged
Updated FBSDK to 9.0 #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
facebook_utils tests fixed. ready to merge! |
|
Thanks for implementing this! Quick question regarding this: I feel like there should be some code to initialize the SDK now? Just wanted to double check that the SDK functionality works without it. |
|
@akmarinov Parse docs indicate that FB SDK should be integrated using this guide, and that already covers FB SDK initialisation. |
|
Where is the approval? Is that ready? |
dhanax
approved these changes
Mar 5, 2021
dsp1589
approved these changes
Mar 5, 2021
dplewis
approved these changes
Mar 5, 2021
|
When we will be able to update ? |
|
1.19.2 is out and available on CocoaPods including this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated FBSDK to v9.0
According to the docs, Facebook introduced a new login method with v9.0 with "limited data mode", which is not covered by this PR. The old login method is still present on v9.0 and working just fine with Parse.
Given that Facebook is deprecating all previous SDKs, I think it would be a good idea to integrate v9.0 now, and leave the new login mode for later (though I haven't check what/if changes are needed).