Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow fully qualified ParseSwift types #397

Merged
merged 4 commits into from
Aug 30, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Aug 30, 2022

New Pull Request Checklist

Issue Description

The ParseSwift framework has public struct named ParseSwift that causes an issue when developers want to use a fully qualified ParseSwift type.

Related issue: #396

Approach

Change the ParseSwift type to Parse and make the updated type internal. This results in zero changes necessary for a user of the SDK and enables the ability to use fully qualified types when necessary. This reverts a change that was added in #54

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: Allow fully qualified ParseSwift types fix: allow fully qualified ParseSwift types Aug 30, 2022
@parse-github-assistant
Copy link

parse-github-assistant bot commented Aug 30, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@cbaker6 cbaker6 linked an issue Aug 30, 2022 that may be closed by this pull request
4 tasks
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #397 (d514ad1) into main (a143c0f) will decrease coverage by 0.01%.
The diff coverage is 91.31%.

@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
- Coverage   89.69%   89.67%   -0.02%     
==========================================
  Files         157      158       +1     
  Lines       15072    15075       +3     
==========================================
  Hits        13519    13519              
- Misses       1553     1556       +3     
Impacted Files Coverage Δ
...s/ParseSwift/Objects/ParseInstallation+async.swift 100.00% <ø> (ø)
...ParseSwift/Objects/ParseInstallation+combine.swift 93.81% <ø> (ø)
Sources/ParseSwift/Objects/ParseObject+async.swift 100.00% <ø> (ø)
...urces/ParseSwift/Objects/ParseObject+combine.swift 92.94% <ø> (ø)
Sources/ParseSwift/Objects/ParseObject.swift 87.29% <ø> (-0.15%) ⬇️
Sources/ParseSwift/Objects/ParseUser+async.swift 100.00% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser+combine.swift 95.71% <ø> (ø)
Sources/ParseSwift/Types/ParseField.swift 100.00% <ø> (ø)
...t/Types/ParsePushPayload/ParsePushPayloadAny.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/QueryWhere.swift 100.00% <ø> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cbaker6 cbaker6 merged commit ed74494 into parse-community:main Aug 30, 2022
@cbaker6 cbaker6 deleted the typeClashing branch August 30, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module name, type name aliasing conflict
1 participant