-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Roles and Relations #54
Conversation
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 76.28% 77.65% +1.37%
==========================================
Files 46 50 +4
Lines 4170 4498 +328
==========================================
+ Hits 3181 3493 +312
- Misses 989 1005 +16
Continue to review full report at Codecov.
|
Conflicts: ParseSwift.xcodeproj/project.pbxproj
- Added aggregate to query. This needs to be tested on a real server.
@TomWFox can you look over the docs? I'm working on the rest of the tests for Role and Relation, but I believe I have most if not all the docs in |
…s causing random failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor requests...
ParseSwift.playground/Pages/13 - Operations.xcplaygroundpage/Contents.swift
Outdated
Show resolved
Hide resolved
Sources/ParseSwift/Authentication/Protocols/ParseAuthentication.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
ParseOperation
along with helper properties/methods toParseObjects
.ParseRole
distinct
,aggregate
(aggregate needs testing on the server),nor
,containedBy
, option not to sort near for GeoQueries, relative time query. SwitchedQuery
to value type. See below...ParseRelation
along with helper properties/methods toParseObjects
.Possible breaking changes:
Query
has been switched to a value type for improved thread safety. You are still able to chain queries, but you may have some warnings to switch fromlet
tovar
. In addition, if you depended on the reference type ofQuery
, you may need to set the return value to the old valuePointer
andtoPointer
- removed fatal error crash when missingobjectId
. Thisthrows
an error instead. The compiler may request for you to addtry
's in your code depending on your implementation.ParseUser
- theauthData
property was added toParseUser
for authentication in the previous PR. The compiler should force any object that conforms toParseUser
to add the property.