Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Roles and Relations #54

Merged
merged 32 commits into from
Jan 21, 2021
Merged

Add Roles and Relations #54

merged 32 commits into from
Jan 21, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jan 17, 2021

  • Finished ParseOperation along with helper properties/methods to ParseObjects.
  • Create ParseRole
  • Query - added distinct, aggregate (aggregate needs testing on the server), nor, containedBy, option not to sort near for GeoQueries, relative time query. Switched Query to value type. See below...
  • Create ParseRelation along with helper properties/methods to ParseObjects.
  • Documentation
  • Improve project naming conventions and structure
  • Add test cases for added functionality
  • Fixed bugs in batch object test cases related to comparing dynamic dates incorrectly that caused random test failures.
  • Playground examples

Possible breaking changes:

  • Query has been switched to a value type for improved thread safety. You are still able to chain queries, but you may have some warnings to switch from let to var. In addition, if you depended on the reference type of Query, you may need to set the return value to the old value
  • Pointerand toPointer - removed fatal error crash when missing objectId. This throws an error instead. The compiler may request for you to add try's in your code depending on your implementation.
  • ParseUser - the authData property was added to ParseUser for authentication in the previous PR. The compiler should force any object that conforms to ParseUser to add the property.

@cbaker6 cbaker6 marked this pull request as draft January 17, 2021 18:34
@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

Merging #54 (ed6ec9d) into main (5d15b43) will increase coverage by 1.37%.
The diff coverage is 82.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   76.28%   77.65%   +1.37%     
==========================================
  Files          46       50       +4     
  Lines        4170     4498     +328     
==========================================
+ Hits         3181     3493     +312     
- Misses        989     1005      +16     
Impacted Files Coverage Δ
Sources/ParseSwift/API/Responses.swift 67.39% <0.00%> (ø)
...rseSwift/Authentication/3rd Party/ParseApple.swift 78.84% <ø> (ø)
...Swift/Authentication/Internal/ParseAnonymous.swift 86.95% <ø> (ø)
...Authentication/Protocols/ParseAuthentication.swift 72.63% <ø> (ø)
Sources/ParseSwift/LiveQuery/LiveQuerySocket.swift 61.40% <ø> (ø)
...t/LiveQuery/Protocols/ParseLiveQueryDelegate.swift 20.00% <ø> (ø)
Sources/ParseSwift/LiveQuery/Subscription.swift 63.26% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser.swift 74.77% <ø> (-0.18%) ⬇️
...ources/ParseSwift/Storage/ParseKeyValueStore.swift 84.00% <ø> (ø)
Sources/ParseSwift/Types/ParseFile.swift 88.23% <ø> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d15b43...ed6ec9d. Read the comment docs.

@cbaker6 cbaker6 marked this pull request as ready for review January 20, 2021 18:57
@cbaker6 cbaker6 requested a review from TomWFox January 20, 2021 18:57
@cbaker6
Copy link
Contributor Author

cbaker6 commented Jan 20, 2021

@TomWFox can you look over the docs?

I'm working on the rest of the tests for Role and Relation, but I believe I have most if not all the docs in

Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor requests...

Sources/ParseSwift/Objects/ParseRole.swift Outdated Show resolved Hide resolved
Sources/ParseSwift/Objects/ParseRole.swift Outdated Show resolved Hide resolved
Sources/ParseSwift/Types/Query.swift Outdated Show resolved Hide resolved
Sources/ParseSwift/Types/ParseRelation.swift Outdated Show resolved Hide resolved
Sources/ParseSwift/Operations/ParseOperation.swift Outdated Show resolved Hide resolved
cbaker6 and others added 2 commits January 21, 2021 12:22
Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@cbaker6
Copy link
Contributor Author

cbaker6 commented Jan 21, 2021

Thanks @TomWFox! I recently added some of the missing query constraints. Not too many (2 additions, with 1 parameter added to 3 others), but can look at them? 6bb02bb

Sources/ParseSwift/Types/Query.swift Outdated Show resolved Hide resolved
Sources/ParseSwift/Types/Query.swift Outdated Show resolved Hide resolved
Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@cbaker6 cbaker6 merged commit 86d4eb7 into main Jan 21, 2021
@cbaker6 cbaker6 deleted the roles branch January 21, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants