Pr/4 #5
Closed
Pr/4 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lowercased API.Method enum cases and added explicit raw values to ensure REST compatibility.
RESTCommand and Result have been removed and replaced with regular async callbacks, as discussed in #3.
If a request fails to return decodable data or an error, a catch all error is returned instead of a fatal error being raised.
This reverts commit a756a25. Reverts to throwing a fatal error if a request doesn't return a valid response.
Some files were only present in the iOS target. This has been fixed, and now all files are present in both targets.
Temprarily removing the SwiftLint build phase to check if that's why Travis is failing to build the project.
This reverts commit 365b29f.
This reverts commit 6f53475.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.