Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr/4 #5

Closed
wants to merge 18 commits into from
Closed

Pr/4 #5

wants to merge 18 commits into from

Commits on Sep 10, 2017

  1. Rename API.Method to follow Swift conventions 

    Lowercased API.Method enum cases and added explicit raw values to ensure REST compatibility.
    @pranjalsatija
    pranjalsatija committed Sep 10, 2017
    Configuration menu
    Copy the full SHA
    3340963 View commit details
    Browse the repository at this point in the history

  2. Cleanup 

    Reorganized to prevent unrelated code from being in the same file.
    @pranjalsatija
    pranjalsatija committed Sep 10, 2017
    Configuration menu
    Copy the full SHA
    71470fd View commit details
    Browse the repository at this point in the history

  3. Remove RESTCommand and Result 

    RESTCommand and Result have been removed and replaced with regular async callbacks, as discussed in #3.
    @pranjalsatija
    pranjalsatija committed Sep 10, 2017
    Configuration menu
    Copy the full SHA
    3e1d8a1 View commit details
    Browse the repository at this point in the history

  4. Add default value for API.Endpoint.makeRequest options parameter

    @pranjalsatija
    pranjalsatija committed Sep 10, 2017
    Configuration menu
    Copy the full SHA
    25251ca View commit details
    Browse the repository at this point in the history

  5. Remove fatal errors when unwrapping optionals 

    If a request fails to return decodable data or an error, a catch all error is returned instead of a fatal error being raised.
    @pranjalsatija
    pranjalsatija committed Sep 10, 2017
    Configuration menu
    Copy the full SHA
    a756a25 View commit details
    Browse the repository at this point in the history

  6. Revert "Remove fatal errors when unwrapping optionals" 

    This reverts commit a756a25.

Reverts to throwing a fatal error if a request doesn't return a valid response.
    @pranjalsatija
    pranjalsatija committed Sep 10, 2017
    Configuration menu
    Copy the full SHA
    e0caeec View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2017

  1. Remove Result.swift

    @pranjalsatija
    pranjalsatija committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    b5788aa View commit details
    Browse the repository at this point in the history

  2. Update Synchronous.swift

    @pranjalsatija
    pranjalsatija committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    700b72e View commit details
    Browse the repository at this point in the history

  3. Add files to all targets 

    Some files were only present in the iOS target. This has been fixed, and now all files are present in both targets.
    @pranjalsatija
    pranjalsatija committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    fbcafac View commit details
    Browse the repository at this point in the history

  4. Remove SwiftLint Build Phase 

    Temprarily removing the SwiftLint build phase to check if that's why Travis is failing to build the project.
    @pranjalsatija
    pranjalsatija committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    6f53475 View commit details
    Browse the repository at this point in the history

  5. Disable SwiftLint for macOS

    @pranjalsatija
    pranjalsatija committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    365b29f View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2017

  1. removes .DS_Store

    @flovilmart
    flovilmart committed Sep 23, 2017
    Configuration menu
    Copy the full SHA
    35569da View commit details
    Browse the repository at this point in the history

  2. Revert "Disable SwiftLint for macOS" 

    This reverts commit 365b29f.
    @flovilmart
    flovilmart committed Sep 23, 2017
    Configuration menu
    Copy the full SHA
    4abccc1 View commit details
    Browse the repository at this point in the history

  3. Revert "Remove SwiftLint Build Phase" 

    This reverts commit 6f53475.
    @flovilmart
    flovilmart committed Sep 23, 2017
    Configuration menu
    Copy the full SHA
    40f5f4a View commit details
    Browse the repository at this point in the history

  4. Removes xcpretty

    @flovilmart
    flovilmart committed Sep 23, 2017
    Configuration menu
    Copy the full SHA
    c08b798 View commit details
    Browse the repository at this point in the history

  5. Adds branch specifier

    @flovilmart
    flovilmart committed Sep 23, 2017
    Configuration menu
    Copy the full SHA
    581162c View commit details
    Browse the repository at this point in the history

  6. Use travis installed swift lint

    @flovilmart
    flovilmart committed Sep 23, 2017
    Configuration menu
    Copy the full SHA
    72361e3 View commit details
    Browse the repository at this point in the history

  7. removes unnecssary lint exclusion

    @flovilmart
    flovilmart committed Sep 23, 2017
    Configuration menu
    Copy the full SHA
    49d76a1 View commit details
    Browse the repository at this point in the history