-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr/4 #5
Closed
Closed
Pr/4 #5
Commits on Sep 10, 2017
-
Rename API.Method to follow Swift conventions
Lowercased API.Method enum cases and added explicit raw values to ensure REST compatibility.
Configuration menu - View commit details
-
Copy full SHA for 3340963 - Browse repository at this point
Copy the full SHA 3340963View commit details -
Reorganized to prevent unrelated code from being in the same file.
Configuration menu - View commit details
-
Copy full SHA for 71470fd - Browse repository at this point
Copy the full SHA 71470fdView commit details -
RESTCommand and Result have been removed and replaced with regular async callbacks, as discussed in #3.
Configuration menu - View commit details
-
Copy full SHA for 3e1d8a1 - Browse repository at this point
Copy the full SHA 3e1d8a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25251ca - Browse repository at this point
Copy the full SHA 25251caView commit details -
Remove fatal errors when unwrapping optionals
If a request fails to return decodable data or an error, a catch all error is returned instead of a fatal error being raised.
Configuration menu - View commit details
-
Copy full SHA for a756a25 - Browse repository at this point
Copy the full SHA a756a25View commit details -
Revert "Remove fatal errors when unwrapping optionals"
This reverts commit a756a25. Reverts to throwing a fatal error if a request doesn't return a valid response.
Configuration menu - View commit details
-
Copy full SHA for e0caeec - Browse repository at this point
Copy the full SHA e0caeecView commit details
Commits on Sep 18, 2017
-
Configuration menu - View commit details
-
Copy full SHA for b5788aa - Browse repository at this point
Copy the full SHA b5788aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 700b72e - Browse repository at this point
Copy the full SHA 700b72eView commit details -
Some files were only present in the iOS target. This has been fixed, and now all files are present in both targets.
Configuration menu - View commit details
-
Copy full SHA for fbcafac - Browse repository at this point
Copy the full SHA fbcafacView commit details -
Temprarily removing the SwiftLint build phase to check if that's why Travis is failing to build the project.
Configuration menu - View commit details
-
Copy full SHA for 6f53475 - Browse repository at this point
Copy the full SHA 6f53475View commit details -
Configuration menu - View commit details
-
Copy full SHA for 365b29f - Browse repository at this point
Copy the full SHA 365b29fView commit details
Commits on Sep 23, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 35569da - Browse repository at this point
Copy the full SHA 35569daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4abccc1 - Browse repository at this point
Copy the full SHA 4abccc1View commit details -
Revert "Remove SwiftLint Build Phase"
This reverts commit 6f53475.
Configuration menu - View commit details
-
Copy full SHA for 40f5f4a - Browse repository at this point
Copy the full SHA 40f5f4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c08b798 - Browse repository at this point
Copy the full SHA c08b798View commit details -
Configuration menu - View commit details
-
Copy full SHA for 581162c - Browse repository at this point
Copy the full SHA 581162cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72361e3 - Browse repository at this point
Copy the full SHA 72361e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49d76a1 - Browse repository at this point
Copy the full SHA 49d76a1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.