Fix Podfile for CocoaPods-1.0 #240
Conversation
exclusive=>true flag for targets was deprecated on cocoapods version 1.0
ghost
added
the
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you! Will merge in as soon as CLA is signed! |
|
@nlutsenko Fixing the build right now... I think I will also create a pull request to add instructions on how to run the project tests on the README. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@nlutsenko giving up for today. It is a problem while importing Facebook SDK: Unfortunately, all the solutions that I found are for people that had installed the Facebook SDK manually, not via cocoapods. It also looks like a bug on Facebook iOS SDK that is marked as solved, but a bunch of people are still complaining: https://developers.facebook.com/bugs/362995353893156/#_=_ |
|
FYI, removing the |
- 'embedded dylibs/frameworks are only supported on iOS 8.0 and later (@rpath/Bolts.framework/Bolts) for architecture i386'
thiagoghisi
force-pushed
the
fix-podfile-for-cocoapods-1-0-0
branch
from
1dc24a3
to
427aac9
Compare
|
@nlutsenko I finally took the time to fix the build. All green now. Let me know if you have any questions. |
|
@nlutsenko let me know if you have any question here. The build is fixed now. |
|
@nlutsenko can we merge this in? waiting on this dependency to upgrade CocoaPods to 1.0 |
|
All done. Sorry for delay. Glad we have this fixed. |
exclusive=>trueflag for targets was deprecated on cocoapods 1.0 release