Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift sample code missing for various sections #21

Closed
hramos opened this issue May 12, 2015 · 12 comments
Closed

Swift sample code missing for various sections #21

hramos opened this issue May 12, 2015 · 12 comments

Comments

@hramos
Copy link
Contributor

hramos commented May 12, 2015

Some of the files in the iOS guide are missing Swift examples (search for "no swift example"):

Docs/en/ios/handling-errors.mdown
Docs/en/ios/in-app-purchases.mdown
Docs/en/ios/local-datastore.mdown
Docs/en/ios/push-notifications.mdown
Docs/en/ios/queries.mdown
Docs/en/ios/user-interface.mdown

@Lucashuang0802
Copy link

Finished editing from the item one to item four in pull request #41

@Lucashuang0802
Copy link

Link #58

nlutsenko added a commit that referenced this issue May 28, 2015
Fixed issues #21: Provide missing Swift doc
@Lucashuang0802
Copy link

#73 This issue can be close @hramos. BTW, I just received the gift yesterday and it's beautiful. Thanks Hector and @nlutsenko .

@Lucashuang0802
Copy link

I will look into it when I have time tonight and hopefully I can make PR tomorrow. Thanks.

@hramos
Copy link
Contributor Author

hramos commented May 28, 2015

Thanks for all your help, it's really appreciated.

hramos added a commit that referenced this issue May 29, 2015
nlutsenko added a commit that referenced this issue Jun 1, 2015
Finished the rest of #21: push notification and relation
@Lucashuang0802
Copy link

#78 is merged. Please check whether there are still missing pieces of Swift codes for iOS. @hramos @nlutsenko

@hramos
Copy link
Contributor Author

hramos commented Jun 3, 2015

Awesome work! This is really appreciated.

I think the only missing pieces are in en/common/relations.mdown, which I missed in my initial pass when this issue was opened.

@Lucashuang0802
Copy link

Okay, I will take a look at that.

@Lucashuang0802
Copy link

I just made a double check and I can't find any // no swift example in the en/common/relations.mdown. Can you double check? Thanks.

@hramos
Copy link
Contributor Author

hramos commented Jun 22, 2015

Looks like we now have full Swift coverage in the Docs. Thank you very much!

@hramos hramos closed this as completed Jun 22, 2015
@Lucashuang0802
Copy link

Sounds good. @ me if you any of them. lol. Thanks for the SWAG again!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants