Proposal: Add a configurable info/error logger #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 91.90% 93.22% +1.31%
==========================================
Files 21 21
Lines 519 531 +12
==========================================
+ Hits 477 495 +18
+ Misses 42 36 -6
Continue to review full report at Codecov.
|
For the sake of backwards compatibility, continue requiring DEBUG=apn to log either of these. For the sake of convenience, allow applications to manually override these loggers on a per-Client instance basis. A more fully-featured logger such as error/warn/info/debug might be useful but overkill if the error conditions are rare in practice. Related to parse-community#59 High volume uses of node-apn may benefit from logging errors but ignore non-errors. Related to parse-community#30 - setLogger can be used by applications to set their own prefix
TysonAndre
force-pushed
the
info-error-logger
branch
from
100c3ea
to
fe7a446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the sake of backwards compatibility, continue requiring DEBUG=apn to
log either of these.
For the sake of convenience, allow applications to manually override
these loggers on a per-Client instance basis.
A more fully-featured logger such as error/warn/info/debug might be
useful but overkill if the error conditions are rare in practice.
Related to #59
High volume uses of node-apn may benefit from logging errors but ignore
non-errors.
Related to #30