Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent filter descriptions #2052

Open
3 tasks done
cyb3rko opened this issue Feb 25, 2022 · 11 comments · Fixed by #2059
Open
3 tasks done

Consistent filter descriptions #2052

cyb3rko opened this issue Feb 25, 2022 · 11 comments · Fixed by #2059
Labels
type:feature New feature or improvement of existing feature

Comments

@cyb3rko
Copy link
Contributor

cyb3rko commented Feb 25, 2022

New Feature / Enhancement Checklist

Current Limitation

There's no limitation, it's just regarding consistency.

image

Feature / Enhancement Description

I feel like the filter "string contains string" should be renamed to "contains" to fit the other filters like "equals" or "starts with" because these do not have "string" in their descriptions either.

Example Use Case

X

Alternatives / Workarounds

X

3rd Party References

X

@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 25, 2022

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@davimacedo
Copy link
Member

Thanks for opening the issue. I think it makes sense. Would be willed to open a PR?

@davimacedo davimacedo added the type:feature New feature or improvement of existing feature label Feb 25, 2022
@cyb3rko
Copy link
Contributor Author

cyb3rko commented Feb 25, 2022

Same answer as mentioned in #2051 :)

@mtrezza
Copy link
Member

mtrezza commented Mar 1, 2022

Since this is only a renaming of a text, you could just replace it and submit the PR. It has probably less to do with web development than with simply opening a PR 🙂

@cyb3rko
Copy link
Contributor Author

cyb3rko commented Mar 1, 2022

Yeah, this one is more simple than the other one.
I just didn't have the time to do it yet, sorry.

@cyb3rko
Copy link
Contributor Author

cyb3rko commented Mar 1, 2022

I just searched for it and haven't found it.
Where is it located?

@davimacedo
Copy link
Member

I believe in the two first file results of this search: https://github.com/parse-community/parse-dashboard/search?q=string+contains+string

@cyb3rko
Copy link
Contributor Author

cyb3rko commented Mar 12, 2022

Take a look, is that it?
I think changing the description in this file should be enough, right?

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-alpha.20

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Mar 16, 2022
@cyb3rko
Copy link
Contributor Author

cyb3rko commented May 30, 2022

@mtrezza
Unfortunately we have to reopen this issue then 😐 according to #2131.

@mtrezza
Copy link
Member

mtrezza commented May 30, 2022

Right, re-opened , let's give it another try 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants