Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String filter input field missing #2131

Closed
4 tasks done
mtrezza opened this issue May 14, 2022 · 4 comments
Closed
4 tasks done

String filter input field missing #2131

mtrezza opened this issue May 14, 2022 · 4 comments
Labels
type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@mtrezza
Copy link
Member

mtrezza commented May 14, 2022

New Issue Checklist

Issue Description

The change in #2059 seems to be causing the filter field to not show.

Steps to reproduce

See #2059 (comment)

Actual Outcome

Field not showing

Expected Outcome

Field should show

Environment

Dashboard

  • Parse Dashboard version: 4.1.2-alpha.1
@parse-github-assistant
Copy link

parse-github-assistant bot commented May 14, 2022

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza added the type:bug Impaired feature or lacking behavior that is likely assumed label May 14, 2022
@mtrezza mtrezza added the block:beta Needs to be resolved before next release on beta branch; remove label afterwards label May 14, 2022
@cyb3rko
Copy link
Contributor

cyb3rko commented May 14, 2022

That's weird, because I only changed the label of the filter, the name is still the same (line 62):

stringContainsString: {
name: 'contains',
field: 'String',
composable: true,
comparable: true
},

And I suppose the lines which add a filter type for the String mode of the filter input are the following:

export const FieldConstraints = {
'Pointer': [ 'exists', 'dne', 'eq', 'neq', 'unique' ],
'Boolean': [ 'exists', 'dne', 'eq', 'unique' ],
'Number': [ 'exists', 'dne', 'eq', 'neq', 'lt', 'lte', 'gt', 'gte', 'unique' ],
'String': [ 'exists', 'dne', 'eq', 'neq', 'starts', 'ends', 'stringContainsString', 'unique' ],

And here the names are used to list the filters, not the labels. I don't get why it doesn't work then.
Line 172 still contains "stringContainsString"

@mtrezza
Copy link
Member Author

mtrezza commented May 17, 2022

Well, I think some more investigation is needed, otherwise we'll have to revert the previous PR to not block the beta release.

@mtrezza mtrezza removed the block:beta Needs to be resolved before next release on beta branch; remove label afterwards label May 30, 2022
@mtrezza
Copy link
Member Author

mtrezza commented May 30, 2022

Closing via db5d23b; reverts #2059.

Revert was done to not block the release pipeline as no-one fixed this issue. @cyb3rko please feel tree to try another attempt and we will gladly review your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Development

No branches or pull requests

2 participants