Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App.js does not produce valid html #2253

Closed
4 tasks done
andrew-polk opened this issue Sep 6, 2022 · 1 comment · Fixed by #2254
Closed
4 tasks done

App.js does not produce valid html #2253

andrew-polk opened this issue Sep 6, 2022 · 1 comment · Fixed by #2254
Labels
type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@andrew-polk
Copy link
Contributor

andrew-polk commented Sep 6, 2022 •
edited
Loading

New Issue Checklist

Issue Description

App.js produces invalid html.
The opening html tag is after the head and the title tag is outside the head.
We suspect this led to our site being flagged by Google as being hacked or containing social engineering content. See https://community.parseplatform.org/t/dashboard-site-being-flagged-as-unsafe-by-google-safe-browsing/2872/7.

Steps to reproduce

Start up parse dashboard. On either the login page or main dashboard page, get the root html document and run it through an html validator.

Actual Outcome

<!DOCTYPE html>
        <head>
          <link rel="shortcut icon" type="image/x-icon" href="/dashboard/favicon.ico" />
          <base href="/dashboard/"/>
          <script>
            PARSE_DASHBOARD_PATH = "/dashboard/";
          </script>
        </head>
        <html>
          <title>Parse Dashboard</title>
          <body>
            <div id="browser_mount"></div>
            <script src="/dashboard/bundles/dashboard.bundle.js"></script>
          </body>
        </html>

Expected Outcome

<!DOCTYPE html>
      <html>
        <head>
          <link rel="shortcut icon" type="image/x-icon" href="/dashboard/favicon.ico" />
          <base href="/dashboard/"/>
          <script>
            PARSE_DASHBOARD_PATH = "/dashboard/";
          </script>
          <title>Parse Dashboard</title>
        </head>
        <body>
          <div id="browser_mount"></div>
          <script src="/dashboard/bundles/dashboard.bundle.js"></script>
        </body>
      </html>

Environment

Dashboard

  • Parse Dashboard version: 4.1.4
  • Browser (Safari, Chrome, Firefox, Edge, etc.): any (I used Chrome)
  • Browser version: 105

Server

  • Parse Server version: any (irrelevant)
  • Operating system: Windows
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): local (any)

Database

  • System (MongoDB or Postgres): MongoDB
  • Database version: irrelevant
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): local (any)

Logs

n/a
@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 6, 2022 •
edited
Loading

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@andrew-polk andrew-polk mentioned this issue Sep 6, 2022
Merged
3 tasks
@mtrezza mtrezza added the type:bug Impaired feature or lacking behavior that is likely assumed label Sep 8, 2022
@mtrezza mtrezza linked a pull request Sep 8, 2022 that will close this issue
fix: dashboard contains invalid html for top-level document #2254
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: dashboard contains invalid html for top-level document andrew-polk/parse-dashboard
2 participants
@mtrezza @andrew-polk