Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QOL changes to Parse Server Example #384

Merged
merged 3 commits into from
Jan 19, 2021

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jan 14, 2021

Adds:

  • Example GitHub workflow
  • Testing utility that imports index.js and boots up a temporary DB, and destroys after tests are complete
  • Example unit test
  • Example code linting

Closes #383

Feel free to let me know your thoughts / what can be improved.

@mtrezza @davimacedo @Moumouls

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit 65ad4b3 into parse-community:master Jan 19, 2021
@davimacedo
Copy link
Member

@dblythy it looks the action is failing after merged. Would you take a look?

@dblythy
Copy link
Member Author

dblythy commented Jan 19, 2021

Yes sorry, I added a failing test as an example of what happens when a test fails. Is this a bad idea?

@davimacedo
Copy link
Member

Yes, I think so. I haven't noticed that as well. But only passing tests would be better.

package.json Show resolved Hide resolved
@parseplatformorg
Copy link

🎉 This change has been released in version 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub Actions to Parse Server Example
4 participants