fix: graphql query transformer drop the condition when where argument…

… has false or 0 value on object field - Change test style - Remove unnecessary assertion Co-authored-by: Antoine Cormouls <contact.antoine.cormouls@gmail.com>
parse-community · Jun 26, 2022 · 32c7ab6 · 32c7ab6
1 parent 42c9543
commit 32c7ab6
Show file tree

Hide file tree

Showing 2 changed files with 121 additions and 1 deletion.
diff --git a/spec/ParseGraphQLServer.spec.js b/spec/ParseGraphQLServer.spec.js
@@ -9516,6 +9516,126 @@ describe('ParseGraphQLServer', () => {
           }
         });
 
+        it('should support where argument on object field that contains false boolean value or 0 number value', async () => {
+          try {
+            const someObjectFieldValue = {
+              foo: { bar: 'baz', qux: true, quux: 100 },
+              number: 10,
+            };
+
+            const object = new Parse.Object('SomeClass');
+            await object.save({
+              someObjectField: someObjectFieldValue,
+            });
+
+            const whereWithQuxFalse = {
+              someObjectField: {
+                notEqualTo: { key: 'foo.bar', value: 'bat' },
+                greaterThan: { key: 'number', value: 9 },
+                lessThan: { key: 'number', value: 11 },
+                equalTo: { key: 'foo.qux', value: false },
+              },
+            };
+            const whereWithQuxTrue = {
+              someObjectField: {
+                ...whereWithQuxFalse.someObjectField,
+                equalTo: { key: 'foo.qux', value: true },
+              },
+            };
+            const whereWithQuux0 = {
+              someObjectField: {
+                notEqualTo: { key: 'foo.bar', value: 'bat' },
+                greaterThan: { key: 'number', value: 9 },
+                lessThan: { key: 'number', value: 11 },
+                equalTo: { key: 'foo.quux', value: 0 },
+              },
+            };
+            const whereWithQuux100 = {
+              someObjectField: {
+                notEqualTo: { key: 'foo.bar', value: 'bat' },
+                greaterThan: { key: 'number', value: 9 },
+                lessThan: { key: 'number', value: 11 },
+                equalTo: { key: 'foo.quux', value: 100 },
+              },
+            };
+            const queryResult = await apolloClient.query({
+              query: gql`
+                query GetSomeObject(
+                  $id: ID!
+                  $whereWithQuxFalse: SomeClassWhereInput
+                  $whereWithQuxTrue: SomeClassWhereInput
+                  $whereWithQuux0: SomeClassWhereInput
+                  $whereWithQuux100: SomeClassWhereInput
+                ) {
+                  someClass(id: $id) {
+                    id
+                    someObjectField
+                  }
+                  someClasses(where: $whereWithQuxFalse) {
+                    edges {
+                      node {
+                        id
+                        someObjectField
+                      }
+                    }
+                  }
+                  someClassesWithQuxTrue: someClasses(where: $whereWithQuxTrue) {
+                    edges {
+                      node {
+                        id
+                        someObjectField
+                      }
+                    }
+                  }
+                  someClassesWithQuux0: someClasses(where: $whereWithQuux0) {
+                    edges {
+                      node {
+                        id
+                        someObjectField
+                      }
+                    }
+                  }
+                  someClassesWithQuux100: someClasses(where: $whereWithQuux100) {
+                    edges {
+                      node {
+                        id
+                        someObjectField
+                      }
+                    }
+                  }
+                }
+              `,
+              variables: {
+                id: object.id,
+                whereWithQuxFalse,
+                whereWithQuxTrue,
+                whereWithQuux0,
+                whereWithQuux100,
+              },
+            });
+
+            const {
+              someClass: getResult,
+              someClasses,
+              someClassesWithQuxTrue,
+              someClassesWithQuux0,
+              someClassesWithQuux100,
+            } = queryResult.data;
+
+            const { someObjectField } = getResult;
+            expect(someObjectField).toEqual(someObjectFieldValue);
+
+            // Checks class query results
+            expect(someClasses.edges.length).toEqual(0);
+            expect(someClassesWithQuxTrue.edges.length).toEqual(1);
+
+            expect(someClassesWithQuux0.edges.length).toEqual(0);
+            expect(someClassesWithQuux100.edges.length).toEqual(1);
+          } catch (e) {
+            handleError(e);
+          }
+        });
+
         it('should support object composed queries', async () => {
           try {
             const someObjectFieldValue1 = {

diff --git a/src/GraphQL/transformers/query.js b/src/GraphQL/transformers/query.js
@@ -108,7 +108,7 @@ const transformQueryConstraintInputToParse = (
      *      }
      *   }
      */
-    if (fieldValue.key && fieldValue.value && parentConstraints && parentFieldName) {
+    if (fieldValue.key && fieldValue.value !== undefined && parentConstraints && parentFieldName) {
       delete parentConstraints[parentFieldName];
       parentConstraints[`${parentFieldName}.${fieldValue.key}`] = {
         ...parentConstraints[`${parentFieldName}.${fieldValue.key}`],