-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AuthenticationProviders should only create a single user with REST API #6385
Comments
This look like expected behavior to me. Lets say I have to two users creating accounts at the same time. Are they two separate users or same user? |
I think that this is a bug.
This answer is "same user", right? Because they are using same SNS account.
For example,
Existing test code test it only in a serial way not In a parallel way. |
@dplewis I got a pain with same issue. 🐛 Sometimes multiple same accounts(having same authData) are created by multiple request from the one user when I use This situation happens by poor connection, slow DB, request by fast double click and so on. I suggest the option for For example, Apple authData's form is new ParseServer({
...
auth: {
kakao: kakaoAuthAdapter,
apple: {
client_id: process.env.APPLE_SIGNIN_CLIENT_ID,
username: 'apple.id'
},
},
...
}) Or in adapter, _createClass(Apple, [{
key: "uniqueUsername",
value: function validateAuthData(authData, options) {
return authData.apple.id
}
...
|
Issue Description
AuthenticationProviders should only create a single user with REST API.
AuthenticationAdapters.spec.js
has a test case for this.This test case try to make two
POST
request with the sameauthData
in a serial way.In a parallel way, it can make double users.
Steps to reproduce
I wrote a test case for this.
Please add this case to
AuthenticationAdapters.spec.js
and run test.Expected Results
Test pass.
Actual Outcome
Test fail
example output
Environment Setup
Server
Database
The text was updated successfully, but these errors were encountered: