SchemaOptions definition not properly added

[mtrezza]

New Issue Checklist

• I am not disclosing a vulnerability.
• I am not just asking a question.
• I have searched through existing issues.
• I can reproduce the issue with the latest version of Parse Server.

Issue Description

The Parse Server options SchemaOptions which were added in #7418 were not properly added to the definition file.

The SchemaOptions are defined in /src/Options/Definitions.js, but when re-building the options with npm run definitions, the options are removed.

Steps to reproduce

1. Run npm run definitions

Actual Outcome

Schema options are removed from /src/Options/Definitions.js.

Expected Outcome

Schema options should be properly re-built.

Environment

Server

• Parse Server version: 5.0.0-alpha.24

[parse-github-assistant]

Thanks for opening this issue!

• 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

[mtrezza]

@sadortun @Moumouls could you take a look?

[dblythy]

What do you think about having npm run definitions ran / checked by the CI?

[mtrezza]

What do you mean by "checked by the CI"?

[dblythy]

Well I’m assuming here that a contributor thought that they had to manually edit the Definitions.js file (even though it says “ Do not manually), instead of adding to index.js. I think it would be good to possibly have a CI check to make sure npm run definitions matches the committed Definitions.js file, so we can be sure no manual editing has been applied.

[mtrezza]

Got it, I think we could simply generate the definitions file again and compare the result with what's been committed. Or do you have a different idea?

[Moumouls]

The source of the problem is simply related to the fact that the definitions were added manually to the auto-generated file

[mtrezza]

Thanks for fixing this, the discussion was about how to prevent that in the future. Generating the definitions file and comparing it to the current definitions seems an easy check for the CI. I opened #7918 so we close this issue with your fix.

[mtrezza]

Closed via #7917