fix: `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` #8766

dplewis · 2023-09-27T05:13:55Z

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

Calling Parse.Cloud.startJob or Parse.Push.send from a Cloud Code function while directAccess is false doesn't return the status Id.

Closes: #8770
Related: parse-community/Parse-SDK-JS#2033

Approach

Support status Id headers in the direct access REST Controller

Tasks

Add tests
Add changes to documentation (guides, repository pages, code comments)
Add security check
Add new Parse Error codes to Parse JS SDK

… is false

parse-github-assistant · 2023-09-27T05:13:58Z

Thanks for opening this pull request!

src/ParseServerRESTController.js

mtrezza

This PR provides a quick fix, but I'm not sure it's a sustainable fix as it duplicates codes across 2 repositories which will be difficult to maintain.

The underlying issue seems to be that the REST controller makes the decision to convert response headers as needed for methods (runJob, sendPush). This has the pattern of a circular dependency where the method depends on the REST controller returning the headers and the REST controller depends on the methods to decide which headers to return.

The REST controller should be caller-agnostic. If there are any response headers it should provide them to the caller, so the caller decides which headers to process further. Just like it does with the response body.

Just imagine that in the future runJob should return the status ID and the value from another header. We would need to start building the response object of runJob in the REST controller which doesn't make sense.

Could the REST Controllers simply pass an additional headers object back to the calling function? This way the runJob can pick up the header and compose the response. This would avoid code duplication, work regardless of REST controller and it provides us more flexibility in the future.

dplewis · 2023-09-28T05:35:17Z

We would have to reuse returnStatus and that could work but getting response headers from xmlhttprequest is a nightmare. The code may looks similar but ParseServerRestController returns headers as a json, JS RestController returns headers as a single string that needs to be parsed.

mtrezza · 2023-10-03T17:24:42Z

Can this PR be closed thanks to parse-community/Parse-SDK-JS#2033?

dplewis · 2023-10-03T17:38:24Z

We have to wait for parse-community/Parse-SDK-JS#2033 to be released for the test cases here to pass.

I've updated the PR to pass headers in the ParseRestController similarly to the JS RestController. The JS SDK will handle the headers.

mtrezza · 2023-10-04T00:09:39Z

That's a great fix; so should be able to merge this in Nov when we'll do a stable release of the JS SDK with that fix included.

nebitrams · 2023-10-07T02:19:41Z

Thank you @mtrezza, @dplewis and team for fixing this. Since I can use directAccess: false as a work around, I am happy to wait for the bug fix in Nov 2023.

mtrezza · 2024-02-15T23:23:55Z

parse-community/Parse-SDK-JS#2033 has been merged, but we cannot use the latest Parse JS SDK release in Parse Server due to #8818; so I believe we need fix #8818 first before we can merge this PR here.

mtrezza

parse-community/Parse-SDK-JS#2033 has been merged and it's in the JS SDK that PS7 is using, but tests fail.

dplewis · 2024-04-12T16:06:36Z

@mtrezza Tests have been updated. This is ready to merge.

mtrezza

Looks good

codecov · 2024-04-13T22:03:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.16%. Comparing base (f1469c6) to head (708d12e).
Report is 6 commits behind head on alpha.

Additional details and impacted files

@@            Coverage Diff             @@
##            alpha    #8766      +/-   ##
==========================================
+ Coverage   94.13%   94.16%   +0.02%     
==========================================
  Files         186      186              
  Lines       14687    14724      +37     
==========================================
+ Hits        13826    13865      +39     
+ Misses        861      859       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# [7.1.0-alpha.6](7.1.0-alpha.5...7.1.0-alpha.6) (2024-04-14) ### Bug Fixes * `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` ([#8766](#8766)) ([5b0efb2](5b0efb2))

parseplatformorg · 2024-04-14T19:43:56Z

🎉 This change has been released in version 7.1.0-alpha.6

# [7.1.0-beta.1](7.0.0...7.1.0-beta.1) (2024-06-30) ### Bug Fixes * `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` ([#8766](#8766)) ([5b0efb2](5b0efb2)) * `Required` option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations ([#8915](#8915)) ([907ad42](907ad42)) * Facebook Limited Login not working due to incorrect domain in JWT validation ([#9122](#9122)) ([9d0bd2b](9d0bd2b)) * Live query throws error when constraint `notEqualTo` is set to `null` ([#8835](#8835)) ([11d3e48](11d3e48)) * Parse Server option `extendSessionOnUse` not working for session lengths < 24 hours ([#9113](#9113)) ([0a054e6](0a054e6)) * Rate limiting can fail when using Parse Server option `rateLimit.redisUrl` with clusters ([#8632](#8632)) ([c277739](c277739)) * SQL injection when using Parse Server with PostgreSQL; fixes security vulnerability [GHSA-c2hr-cqg6-8j6r](GHSA-c2hr-cqg6-8j6r) ([#9167](#9167)) ([2edf1e4](2edf1e4)) ### Features * Add `silent` log level for Cloud Code ([#8803](#8803)) ([5f81efb](5f81efb)) * Add server security check status `security.enableCheck` to Features Router ([#8679](#8679)) ([b07ec15](b07ec15)) * Prevent Parse Server start in case of unknown option in server configuration ([#8987](#8987)) ([8758e6a](8758e6a)) * Upgrade to @parse/push-adapter 6.0.0 ([#9066](#9066)) ([18bdbf8](18bdbf8)) * Upgrade to @parse/push-adapter 6.2.0 ([#9127](#9127)) ([ca20496](ca20496)) * Upgrade to Parse JS SDK 5.2.0 ([#9128](#9128)) ([665b8d5](665b8d5))

parseplatformorg · 2024-06-30T02:03:46Z

🎉 This change has been released in version 7.1.0-beta.1

# [7.1.0](7.0.0...7.1.0) (2024-06-30) ### Bug Fixes * `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` ([#8766](#8766)) ([5b0efb2](5b0efb2)) * `Required` option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations ([#8915](#8915)) ([907ad42](907ad42)) * Facebook Limited Login not working due to incorrect domain in JWT validation ([#9122](#9122)) ([9d0bd2b](9d0bd2b)) * Live query throws error when constraint `notEqualTo` is set to `null` ([#8835](#8835)) ([11d3e48](11d3e48)) * Parse Server option `extendSessionOnUse` not working for session lengths < 24 hours ([#9113](#9113)) ([0a054e6](0a054e6)) * Rate limiting can fail when using Parse Server option `rateLimit.redisUrl` with clusters ([#8632](#8632)) ([c277739](c277739)) * SQL injection when using Parse Server with PostgreSQL; fixes security vulnerability [GHSA-c2hr-cqg6-8j6r](GHSA-c2hr-cqg6-8j6r) ([#9167](#9167)) ([2edf1e4](2edf1e4)) ### Features * Add `silent` log level for Cloud Code ([#8803](#8803)) ([5f81efb](5f81efb)) * Add server security check status `security.enableCheck` to Features Router ([#8679](#8679)) ([b07ec15](b07ec15)) * Prevent Parse Server start in case of unknown option in server configuration ([#8987](#8987)) ([8758e6a](8758e6a)) * Upgrade to @parse/push-adapter 6.0.0 ([#9066](#9066)) ([18bdbf8](18bdbf8)) * Upgrade to @parse/push-adapter 6.2.0 ([#9127](#9127)) ([ca20496](ca20496)) * Upgrade to Parse JS SDK 5.2.0 ([#9128](#9128)) ([665b8d5](665b8d5))

parseplatformorg · 2024-06-30T02:24:11Z

🎉 This change has been released in version 7.1.0

fix: Return Parse.Job and Parse.Push statusId when directAccess…

5dbae2b

… is false

dplewis mentioned this pull request Sep 27, 2023

Parse.Cloud.startJob not returning jobStatusId #8770

Closed

4 tasks

dplewis assigned mtrezza Sep 27, 2023

mtrezza removed their assignment Sep 27, 2023

dplewis requested a review from mtrezza September 27, 2023 21:05

mtrezza reviewed Sep 27, 2023

View reviewed changes

src/ParseServerRESTController.js Outdated Show resolved Hide resolved

mtrezza changed the title ~~fix: Return Parse.Job and Parse.Push statusId when directAccess is false~~ fix: Parse.Job and Parse.Push not returning status ID when Parse Server option directAccess: true Sep 27, 2023

mtrezza changed the title ~~fix: Parse.Job and Parse.Push not returning status ID when Parse Server option directAccess: true~~ fix: Parse.Cloud.startJob and Parse.Push not returning status ID when Parse Server option directAccess: true Sep 27, 2023

mtrezza changed the title ~~fix: Parse.Cloud.startJob and Parse.Push not returning status ID when Parse Server option directAccess: true~~ fix: Parse.Cloud.startJob and Parse.Push.send not returning status ID when Parse Server option directAccess: true Sep 27, 2023

mtrezza changed the title ~~fix: Parse.Cloud.startJob and Parse.Push.send not returning status ID when Parse Server option directAccess: true~~ fix: Parse.Cloud.startJob and Parse.Push.send not returning status ID when setting Parse Server option directAccess: true Sep 27, 2023

mtrezza requested changes Sep 28, 2023

View reviewed changes

dplewis mentioned this pull request Sep 28, 2023

refactor: Return headers in RESTController requests parse-community/Parse-SDK-JS#2033

Merged

2 tasks

return headers in RestController

74e2a89

Merge branch 'alpha' into statusId-directAccess

5f5e98a

mtrezza added 2 commits October 7, 2023 13:45

Merge branch 'alpha' into statusId-directAccess

cbd8a76

Merge branch 'alpha' into statusId-directAccess

83f69c6

mtrezza added 2 commits March 10, 2024 15:56

Merge branch 'alpha' into statusId-directAccess

2b57e2d

Merge branch 'alpha' into statusId-directAccess

72998ab

mtrezza approved these changes Mar 23, 2024

View reviewed changes

mtrezza requested changes Mar 23, 2024

View reviewed changes

dplewis added 3 commits April 5, 2024 18:15

Merge branch 'alpha' into statusId-directAccess

9dfdb40

Merge remote-tracking branch 'upstream/alpha' into statusId-directAccess

31632a9

update tests

01ad23a

dplewis added 2 commits April 12, 2024 10:51

batch request test

2bf3ac3

remove fit

aa4960c

dplewis requested a review from mtrezza April 12, 2024 16:06

mtrezza approved these changes Apr 12, 2024

View reviewed changes

mtrezza added 2 commits April 13, 2024 22:44

Merge branch 'alpha' into statusId-directAccess

3fcc4f4

Merge branch 'alpha' into statusId-directAccess

8867a49

Merge branch 'alpha' into statusId-directAccess

708d12e

mtrezza merged commit 5b0efb2 into parse-community:alpha Apr 14, 2024
24 of 26 checks passed

parseplatformorg added the state:released-alpha Released as alpha version label Apr 14, 2024

dplewis deleted the statusId-directAccess branch April 18, 2024 21:54

parseplatformorg added the state:released-beta Released as beta version label Jun 30, 2024

parseplatformorg added the state:released Released as stable version label Jun 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` #8766

fix: `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` #8766

dplewis commented Sep 27, 2023 •

edited by mtrezza

Loading

parse-github-assistant bot commented Sep 27, 2023 •

edited

Loading

mtrezza left a comment •

edited

Loading

dplewis commented Sep 28, 2023 •

edited

Loading

mtrezza commented Oct 3, 2023

dplewis commented Oct 3, 2023

mtrezza commented Oct 4, 2023 •

edited

Loading

nebitrams commented Oct 7, 2023

mtrezza commented Feb 15, 2024

mtrezza left a comment •

edited

Loading

dplewis commented Apr 12, 2024

mtrezza left a comment

codecov bot commented Apr 13, 2024 •

edited

Loading

parseplatformorg commented Apr 14, 2024

parseplatformorg commented Jun 30, 2024

parseplatformorg commented Jun 30, 2024

fix: Parse.Cloud.startJob and Parse.Push.send not returning status ID when setting Parse Server option directAccess: true #8766

fix: Parse.Cloud.startJob and Parse.Push.send not returning status ID when setting Parse Server option directAccess: true #8766

Conversation

dplewis commented Sep 27, 2023 • edited by mtrezza Loading

Pull Request

Issue

Approach

Tasks

parse-github-assistant bot commented Sep 27, 2023 • edited Loading

Thanks for opening this pull request!

mtrezza left a comment • edited Loading

Choose a reason for hiding this comment

dplewis commented Sep 28, 2023 • edited Loading

mtrezza commented Oct 3, 2023

dplewis commented Oct 3, 2023

mtrezza commented Oct 4, 2023 • edited Loading

nebitrams commented Oct 7, 2023

mtrezza commented Feb 15, 2024

mtrezza left a comment • edited Loading

Choose a reason for hiding this comment

dplewis commented Apr 12, 2024

mtrezza left a comment

Choose a reason for hiding this comment

codecov bot commented Apr 13, 2024 • edited Loading

Codecov Report

parseplatformorg commented Apr 14, 2024

parseplatformorg commented Jun 30, 2024

parseplatformorg commented Jun 30, 2024

fix: `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` #8766

fix: `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` #8766

dplewis commented Sep 27, 2023 •

edited by mtrezza

Loading

parse-github-assistant bot commented Sep 27, 2023 •

edited

Loading

mtrezza left a comment •

edited

Loading

dplewis commented Sep 28, 2023 •

edited

Loading

mtrezza commented Oct 4, 2023 •

edited

Loading

mtrezza left a comment •

edited

Loading

codecov bot commented Apr 13, 2024 •

edited

Loading