Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest Parse SDK breaks test #8818

Closed
4 tasks done
mtrezza opened this issue Nov 18, 2023 · 2 comments · Fixed by #9022
Closed
4 tasks done

Upgrade to latest Parse SDK breaks test #8818

mtrezza opened this issue Nov 18, 2023 · 2 comments · Fixed by #9022
Labels
block:major Needs to be resolved before next major release; remove label afterwards type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@mtrezza
Copy link
Member

mtrezza commented Nov 18, 2023

New Issue Checklist

Issue Description

Upgrading to latest Parse SDK (4.3.1 as of writing) breaks the test:

  1. Security Advisory GHSA-8w3j-g983-8jh5 should validate credentials first and check if account already linked afterwards ()
  • Expected 208 to equal 206.

The test specifically expects 206 instead of 208 (as commented in the test), so it doesn't seem to be a deliberate change but rather a bug.

Steps to reproduce

See #8816.

Actual Outcome

Test fails.

Expected Outcome

Test passes.

Copy link

parse-github-assistant bot commented Nov 18, 2023

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza added the type:bug Impaired feature or lacking behavior that is likely assumed label Nov 18, 2023
@mtrezza mtrezza changed the title Upgrading to latest Parse breaks test Upgrading to latest Parse SDK breaks test Nov 18, 2023
@mtrezza mtrezza changed the title Upgrading to latest Parse SDK breaks test Upgrade to latest Parse SDK breaks test Nov 18, 2023
@mtrezza mtrezza added the block:major Needs to be resolved before next major release; remove label afterwards label Feb 15, 2024
@mtrezza
Copy link
Member Author

mtrezza commented Mar 17, 2024

Thanks to @dblythy this issue can be closed with #9022.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block:major Needs to be resolved before next major release; remove label afterwards type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
1 participant