Add APNS client #235
Merged
Add APNS client #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangmengyan95
force-pushed
the
wangmengyan.add_apns_client
branch
from
9ebce6c
to
81a5a8f
Compare
|
cc @fantasist for review |
| * @param {Array} deviceTokens A array of device tokens | ||
| * @returns {Object} A promise which is resolved immediately | ||
| */ | ||
| APNS.prototype.send = function(data, deviceTokens) { |
There was a problem hiding this comment.
No, internally the library just sends the notifications one by one, so we do not need to have size limitation.
|
LGTM. One issue is how to deal with dev vs. prod device tokens. You'll probably need a higher layer that selects the appropriate APNs connection to use (dev or prod) based on the bundle id of the app (available in the "appIdentifier" field of the installation). |
|
Okay, seems fine to me. We can add the connection-selecting behavior in some higher-level module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.