Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle queries with equalTo on objectId and relation conditions #2472

Merged

Conversation

JeremyPlease
Copy link
Contributor

This is done by converting shorthand $eq condition on objectId (ie. .equalTo('objectId', id)) to $eq condition instead of clobbering when there are relation conditions.

Tests have been added for this case and now pass.

(some additional conversation here)

…ions

This is done by converting shorthand $eq condition to $eq condition instead of clobbering.
@codecov-io
Copy link

codecov-io commented Aug 6, 2016

Current coverage is 91.88% (diff: 100%)

Merging #2472 into master will increase coverage by <.01%

@@             master      #2472   diff @@
==========================================
  Files            95         95          
  Lines         10698      10703     +5   
  Methods        1310       1310          
  Messages          0          0          
  Branches       1739       1741     +2   
==========================================
+ Hits           9829       9834     +5   
  Misses          869        869          
  Partials          0          0          

Powered by Codecov. Last update 36891f4...ef21dcb

@flovilmart
Copy link
Contributor

It seems to be looking good, Just a question, do we need to keep the IDfromString into to $in array?

@drew-gross drew-gross merged commit f27dff0 into parse-community:master Aug 8, 2016
@JeremyPlease
Copy link
Contributor Author

@flovilmart Looks like @drew-gross liked this PR enough to merge it.

To answer your question though, I don't think it's necessary to add the idFromString to the $in in DatabaseController.addInObjectIdsIds.

But there's also no harm in having the object id both $in and $eq, so this merged PR should still be good.

@flovilmart
Copy link
Contributor

That'a all good! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants