Patch handleShutdown feature #4361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4361 +/- ##
==========================================
+ Coverage 92.66% 92.74% +0.08%
==========================================
Files 119 119
Lines 8435 8438 +3
==========================================
+ Hits 7816 7826 +10
+ Misses 619 612 -7
Continue to review full report at Codecov.
|
|
@vitaly-t looks good to go, can you look this over? |
|
@dplewis seems fine to me ;) |
|
@flovilmart can you add @vitaly-t to the team? |
|
Only if @vitaly-t wants to ;) let me know! |
|
I don't mind 😄 |
dplewis
approved these changes
Nov 18, 2017
flovilmart
approved these changes
Nov 18, 2017
|
@trylovetom thanks much needed |
|
I am currently rewriting all the documentation related to shutting down the library/pool (no functional changes) ;) Will ping when done ;) |
|
Library de-initialization has been fully updated (documentation). |
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* Add handleShutdown Test of MongoStorageAdapter. * Add `handleShutdown` function in PostgresStorageAdapter, with it's test. * Replace the _pgp to _client * Use `adapter._client.$pool.ending` to ckeck is ending * Add `handleShutdown()` in ParseServer.spec.js * Trigger * Set Server to Default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch handle Shutdown spec of ParseServer.spce.js
Patch handle Shutdown spec of PostgresStorageAdapter.spec.js
Patch handle Shutdown spec of MongoStorageAdapter.spec.js