Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.7.2 #5872

Merged
merged 1 commit into from Jul 31, 2019
Merged

3.7.2 #5872

merged 1 commit into from Jul 31, 2019

Conversation

davimacedo
Copy link
Member

No description provided.

@davimacedo davimacedo requested a review from dplewis July 31, 2019 04:27
@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #5872 into master will increase coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5872      +/-   ##
==========================================
+ Coverage   93.14%   93.73%   +0.58%     
==========================================
  Files         153      153              
  Lines       10638    10638              
==========================================
+ Hits         9909     9971      +62     
+ Misses        729      667      -62
Impacted Files Coverage Δ
src/RestWrite.js 93.89% <0%> (+0.49%) ⬆️
src/Controllers/LoggerController.js 91.57% <0%> (+1.05%) ⬆️
src/Adapters/Cache/RedisCacheAdapter/index.js 100% <0%> (+84.09%) ⬆️
...dapters/Cache/RedisCacheAdapter/KeyPromiseQueue.js 95.45% <0%> (+95.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bde96a9...2c9c439. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 31, 2019 •
edited

Codecov Report

Merging #5872 into master will increase coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5872      +/-   ##
==========================================
+ Coverage   93.14%   93.73%   +0.58%     
==========================================
  Files         153      153              
  Lines       10638    10638              
==========================================
+ Hits         9909     9971      +62     
+ Misses        729      667      -62
Impacted Files Coverage Δ
src/RestWrite.js 93.89% <0%> (+0.49%) ⬆️
src/Controllers/LoggerController.js 91.57% <0%> (+1.05%) ⬆️
src/Adapters/Cache/RedisCacheAdapter/index.js 100% <0%> (+84.09%) ⬆️
...dapters/Cache/RedisCacheAdapter/KeyPromiseQueue.js 95.45% <0%> (+95.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bde96a9...2c9c439. Read the comment docs.

@davimacedo davimacedo requested a review from TomWFox July 31, 2019 07:37
@davimacedo
Copy link
Member Author

@dplewis can I release 3.7.2? I am concerned with the current npm version that is not building.

@dplewis
Copy link
Member

dplewis commented Jul 31, 2019

It should be good to go. I make it a habit of running the latest commit against the JS-SDK before every release.

@davimacedo davimacedo merged commit fe18fe0 into master Jul 31, 2019
@TomWFox TomWFox deleted the 3.7.2 branch August 2, 2019 22:05
@TomWFox TomWFox added the release label Mar 1, 2020
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@davimacedo
3.7.2 (parse-community#5872)
7be9217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomWFox TomWFox TomWFox approved these changes

@dplewis dplewis Awaiting requested review from dplewis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davimacedo @dplewis @TomWFox