Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tests from 4.4.3 to 4.4.4 #7184

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

davimacedo
Copy link
Member

New Pull Request Checklist

  • [ X ] I am not disclosing a vulnerability.
  • I am creating this PR in reference to an issue.

Issue Description

Mongo 4.4.4 was released. This PR bumps tests to use this latest version.

Related issue: FILL_THIS_OUT

Approach

TODOs before merging

  • Add test cases
  • [ X ] Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • [ X ] Add security check
  • Add new Parse Error codes to Parse JS SDK
  • ...

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #7184 (3d11c7c) into master (762cddd) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7184      +/-   ##
==========================================
+ Coverage   94.00%   94.02%   +0.02%     
==========================================
  Files         172      172              
  Lines       12834    12834              
==========================================
+ Hits        12064    12067       +3     
+ Misses        770      767       -3     
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.51% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 762cddd...3d11c7c. Read the comment docs.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm happy to see that this self-check works. We are literally updating the environments within hours of new MongoDB releases.

@mtrezza mtrezza merged commit dc1133d into parse-community:master Feb 12, 2021
dplewis pushed a commit that referenced this pull request Feb 21, 2021
* Change tests from 4.4.3 to 4.4.4

* Add entry to changelog
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@mtrezza mtrezza mentioned this pull request Mar 12, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants