Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Become on non existing user #741

Closed
wants to merge 1 commit into from
Closed

Become on non existing user #741

wants to merge 1 commit into from

Conversation

flessard
Copy link
Contributor

@flessard flessard commented Mar 1, 2016

Fix bug where become return invalid session if the pointer to user
doesn't exist

Fix bug where become return invalid session if the pointer to user
doesn't exist
@flovilmart
Copy link
Contributor

We may wanna destroy the session when user gets deleted instead no? @drew-gross what do you think?

@drew-gross
Copy link
Contributor

Destroying session for deleted user seems to make sense, yes. Have you checked what Parse.com does? Also I recall some issue where the SDKs would start failing when their session was destroyed, so maybe that's why we didn't destroy it.

@flovilmart
Copy link
Contributor

If user is deleted, session token should be invalidated at least. @flessard can you check the current behavior on parse.com or you want me to check it out?

Other thing to check is to see when calling include on a key and the included object don't exist. Should the pointer getting soft-deleted from the response? I would tend to say so.

@flessard
Copy link
Contributor Author

flessard commented Mar 2, 2016

@flovilmart Yes if you can check it out, i would appreciate it.

I agree whit you @flovilmart, if the pointer getting don't exist, Should soft-deleted from the response.

@flovilmart
Copy link
Contributor

@flessard so I can confirm that missing includes are resolved to undefined, and that the pointer object is not forwarded to the client. When not calling include on the key, the pointer is still there in the client.

@flovilmart
Copy link
Contributor

Superseded by #777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants