refactor: remove restricted session field #7543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrezza
changed the title
Codecov Report
@@ Coverage Diff @@
## master #7543 +/- ##
==========================================
- Coverage 93.96% 93.93% -0.03%
==========================================
Files 181 181
Lines 13279 13279
==========================================
- Hits 12477 12474 -3
- Misses 802 805 +3
Continue to review full report at Codecov.
|
mtrezza
changed the title
davimacedo
approved these changes
Sep 3, 2021
dblythy
approved these changes
Sep 3, 2021
|
🎉 This change has been released in version 5.0.0-beta.1 |
3 tasks
Merged
|
🎉 This change has been released in version 5.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
The
_Sessionfieldrestrictedfor the feature of restricted sessions is not in use by Parse Server internally. It is a code artifact of a feature that according to comments has not been ported from Parse.com to Open Source Parse Server.This is a Parse Server internal field without any internal logic attached to it. The field is unlikely to be used by developers, so instead of deprecating it, we'll remove the field as a sudden breaking change with Parse Server 5.0. If a developer was using the field, the change for a developer would simply be setting the field
falsein theSession.beforeSavetrigger.See
Related issue: 6612
Approach
_Sessionfieldrestrictedfrom schemarestrictedtofalseby default when creating a new sessionTODOs before merging