Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix docker image pushing to Docker Hub #7548

Merged
merged 16 commits into from
Sep 7, 2021
Merged

ci: Fix docker image pushing to Docker Hub #7548

merged 16 commits into from
Sep 7, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Sep 4, 2021

New Pull Request Checklist

Issue Description

Related issue: #7547

Approach

Use GitHub Actions to push to Docker hub during merges of PRs and releases. Merges to the master branch push the latest image to latest on Docker Hub and releases push the latest release with the same tag name. You can see the tags this creates using my research repo: https://hub.docker.com/repository/docker/netreconlab/parse-dashboard

This builds images for multiple architectures as oppose to just Intel. Builds for all of same architectures as it’s dependency image, node:lts-alpine except for linux/ppc64le and linux/s390x as those both currently fail.

A side-effect is it creates another tag on docker-hub called master, which I guess could be useful if something else is pushed after latest

TODOs before merging

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 4, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #7548 (a6f2a79) into master (5ab974d) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7548      +/-   ##
==========================================
- Coverage   93.97%   93.93%   -0.05%     
==========================================
  Files         181      181              
  Lines       13279    13279              
==========================================
- Hits        12479    12473       -6     
- Misses        800      806       +6     
Impacted Files Coverage Δ
src/LiveQuery/ParseWebSocketServer.js 93.33% <100.00%> (ø)
src/batch.js 91.37% <0.00%> (-1.73%) ⬇️
src/ParseServerRESTController.js 97.01% <0.00%> (-1.50%) ⬇️
src/Adapters/Files/GridFSBucketAdapter.js 79.50% <0.00%> (-0.82%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.47% <0.00%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ab974d...a6f2a79. Read the comment docs.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Sep 4, 2021

If you want to add docker images for missing versions on docker hub (4.5.2 - 4.10.3), cherry pick this commit, place it in the respective release branch, and in docker-publish.yml change latest=true to latest=false, then re-run the action that released each version.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Sep 5, 2021

Corrected a spelling error that's been around for awhile:

logger.info('Parse LiveQuery Server starts running');

@mtrezza mtrezza changed the title Merges push docker image to Docker Hub ci: Fix docker image pushing to Docker Hub Sep 7, 2021
@mtrezza mtrezza merged commit 24e9bdc into parse-community:master Sep 7, 2021
@cbaker6
Copy link
Contributor Author

cbaker6 commented Sep 7, 2021

It looks like the multi-platform images worked! https://hub.docker.com/r/parseplatform/parse-server/tags?page=1&ordering=last_updated

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@cbaker6 cbaker6 mentioned this pull request Nov 17, 2021
4 tasks
@cbaker6 cbaker6 deleted the docker branch November 22, 2021 18:42
@mtrezza mtrezza mentioned this pull request Mar 12, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants