refactor: modernize HTTPRequest tests

[brandongregoryscott]

New Pull Request Checklist

• I am not disclosing a vulnerability.
• I am creating this PR in reference to an issue.

Issue Description

Refactor some existing tests to use async/await as described in #7563. Additionally, removes unnecessary done callbacks, and fixes some deprecation warnings with the Buffer constructor.

Related issue: Modernize Codebase #7563

Approach

Tests were refactored using a red/green testing strategy. All functionality/guards of the tests should remain the same.

TODOs before merging

None that I am aware of

[parse-github-assistant]

Thanks for opening this pull request!

• ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

[dblythy]

Yay! Thanks for this, i'm glad to see someone else working towards cleaning up the tests 🎉

[brandongregoryscott]

Yay! Thanks for this, i'm glad to see someone else working towards cleaning up the tests 🎉

Of course! Happy to help out. Let me know if there's anything I missed or could be written a better way 😃

[dblythy]

I would normally say to prefer expectAsync.toBeRejectedWith but I know with HTTP errors it's pretty much impossible to expect the full error response.

The other point I would make is to prefer template literal syntax in the URL request. But other than that looks good!

[codecov]

Codecov Report

Merging #7604 (32368a7) into master (caee281) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 32368a7 differs from pull request most recent head ba97e90. Consider uploading reports for the commit ba97e90 to get more accurate results

@@           Coverage Diff           @@
##           master    #7604   +/-   ##
=======================================
  Coverage   93.94%   93.95%           
=======================================
  Files         181      181           
  Lines       13319    13319           
=======================================
+ Hits        12513    12514    +1     
+ Misses        806      805    -1     

Impacted Files	Coverage Δ
src/ParseServerRESTController.js	97.01% <0.00%> (-1.50%)	⬇️
src/RestWrite.js	94.20% <0.00%> (+0.15%)	⬆️
src/Adapters/Files/GridFSBucketAdapter.js	80.32% <0.00%> (+0.81%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caee281...ba97e90. Read the comment docs.

[mtrezza]

Nice! Code modernization is too often overlooked unfortunately, even more glad to see this PR!

[parse-github-assistant]

I will reformat the title to use the proper commit message syntax.

[brandongregoryscott]

Thanks for cleaning up the changelog & title! 😃

[dblythy]

@brandongregoryscott if you would like to help with the modernization, cleaning up the tests really help. It gets a little more difficult with core code as we don't want to introduce huge merge conflicts that discourage open PRs. If you're thinking of cleaning up any code, feel free to open a draft PR at its inception and we can discuss if it's good to go, or if it's better to wait until conflicting PRs are merged.

Thanks again for this PR and welcome to the Parse Contributor community 😃

[parseplatformorg]

🎉 This change has been released in version 5.0.0-beta.1

[parseplatformorg]

🎉 This change has been released in version 5.0.0