feat: Add support for $eq in LiveQuery #7607

sadakchap · 2021-10-05T15:49:22Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

As per this issue, currently it is not possible to combine equalTo clause with any other clauses and vice-versa using Parse-SDK-JS. After adding support for combining equalTo clause with other clauses in Parse-SDK-JS's pr.

We need to add support equalTo for LiveQuery, so that it triggers correct events for client.

Related issue: #7606

Approach

add support for $eq query in LiveQuery's matchKeyConstraints.

TODOs before merging

Add test cases

parse-github-assistant · 2021-10-05T15:49:25Z

Thanks for opening this pull request!

❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

codecov · 2021-10-05T16:10:34Z

Codecov Report

Merging #7607 (c4a2ef9) into alpha (a5ffb95) will decrease coverage by 7.12%.
The diff coverage is 83.33%.

❗ Current head c4a2ef9 differs from pull request most recent head dd3ce1a. Consider uploading reports for the commit dd3ce1a to get more accurate results

@@            Coverage Diff             @@
##            alpha    #7607      +/-   ##
==========================================
- Coverage   93.95%   86.82%   -7.13%     
==========================================
  Files         183      183              
  Lines       13655    13667      +12     
==========================================
- Hits        12830    11867     -963     
- Misses        825     1800     +975

Impacted Files	Coverage Δ
src/LiveQuery/QueryTools.js	`94.05% <83.33%> (-0.68%)`	⬇️
src/Adapters/Storage/Mongo/MongoCollection.js	`4.76% <0.00%> (-92.86%)`	⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js	`11.99% <0.00%> (-81.38%)`	⬇️
src/Adapters/Cache/RedisCacheAdapter.js	`12.28% <0.00%> (-75.44%)`	⬇️
src/Adapters/Files/GridFSBucketAdapter.js	`10.65% <0.00%> (-68.86%)`	⬇️
...rc/Adapters/Storage/Mongo/MongoSchemaCollection.js	`35.48% <0.00%> (-62.37%)`	⬇️
src/Adapters/Storage/Mongo/MongoTransform.js	`48.51% <0.00%> (-39.60%)`	⬇️
src/Adapters/Files/GridStoreAdapter.js	`13.04% <0.00%> (-33.34%)`	⬇️
src/Routers/SessionsRouter.js	`65.71% <0.00%> (-25.72%)`	⬇️
src/Routers/AggregateRouter.js	`88.00% <0.00%> (-12.00%)`	⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5ffb95...dd3ce1a. Read the comment docs.

mtrezza · 2021-10-13T09:51:29Z

@sadakchap I have followed the dashboard "is null" filter issue until here:

parse-community/parse-dashboard#1721 > parse-community/Parse-SDK-JS#1373 -> #7607

Is this PR the current stopper?

sadakchap · 2021-10-13T12:31:38Z

Is this PR the current stopper?

I think so, with this PR, also all failing test should pass in parse-community/Parse-SDK-JS#1373. Then we can make changes accordingly in parse-community/parse-dashboard#1721 to get "is null" filter for dashboard.

mtrezza · 2021-10-13T14:01:15Z

Do you need a hand with this PR, or this ready for review?

sadakchap · 2021-10-13T16:46:22Z

Do you need a hand with this PR, or this ready for review?

I think it is ready for review.

mtrezza · 2021-10-13T17:15:46Z

Oh even better, I'll take a look..

mtrezza · 2021-10-13T17:20:38Z

Could you merge master into this and add tests for LiveQuery?

mtrezza · 2021-10-30T08:47:11Z

@sadakchap Just a friendly ping, if you could add the tests that would be great, then we can merge and close the dashboard null filter issue as well. 🙂

…server into feat/sendLiveQueryEvent

…feat/sendLiveQueryEvent

mtrezza · 2021-11-17T12:34:15Z

@sadakchap please let me know when this is ready for review.

mtrezza · 2022-01-01T22:11:18Z

@sadakchap is this PR ready for review?

…server into feat/sendLiveQueryEvent

sadakchap · 2022-01-06T06:01:31Z

@sadakchap is this PR ready for review?

Yes @mtrezza, I believe it is ready to be reviewed now.

mtrezza · 2022-01-06T21:06:04Z

spec/QueryTools.spec.js

@@ -255,6 +255,71 @@ describe('matchesQuery', function () {
    expect(matchesQuery(img, q)).toBe(false);
  });

+  it('matches on queries with new format #parse-SDK-JS/pull/1373', function () {


How is this related to "add support for $eq in LiveQuery"? This is not a LiveQuery test. Is this a test for parse-community/Parse-SDK-JS#1373 which is a separate issue?

Since in parse-community/Parse-SDK-JS#1373, we are changing the format of query. There are certain LiveQuery tests(parse-sdk-js) which are failing because parse-server doesn't support new query format for LiveQuery.

So, we added support for new query format in LiveQuery in parse-server.

Not sure I follow; is parse-community/Parse-SDK-JS#1373 a requirement for this PR? I don't think so, otherwise the tests in this PR wouldn't already pass.

Actually its the other, please follow this parse-community/Parse-SDK-JS#1373 (comment)

So I understand that the tests in parse-community/Parse-SDK-JS#1373 will only pass when this PR (#7607) has been merged. But they relate to 2 different features:

add support for $eq in LiveQuery

add support to "combine equalTo clauses with [other] clauses"

So why is parse-community/Parse-SDK-JS#1373 mentioned in this test case if this PR (#7607) has no dependency on parse-community/Parse-SDK-JS#1373, only the other way around?

@mtrezza sorry, I could not understand you properly, could you please elaborate a bit more?

Sure, it seems these are 2 different features:

feat: Add support for $eq in LiveQuery #7607

feat: combine equalTo clauses with clauses Parse-SDK-JS#1373

Even if parse-community/Parse-SDK-JS#1373 never gets merged, we would still want to merge #7607 as a feature, right? So I don't understand why the tests in #7607 mention parse-community/Parse-SDK-JS#1373:

it('matches on queries with new format #parse-SDK-JS/pull/1373', function () {

cbaker6 · 2024-07-19T13:52:13Z

@mtrezza i think you can close this via #8614

mtrezza · 2024-07-21T13:07:24Z

Closing via #8614

parse-github-assistant · 2024-07-21T13:08:00Z

I will reformat the title to use the proper commit message syntax.

feat(LiveQuery): Support $eq

55b68ea

sadakchap mentioned this pull request Oct 5, 2021

feat: combine equalTo clauses with clauses parse-community/Parse-SDK-JS#1373

Open

5 tasks

sadakchap changed the title ~~feat(LiveQuery): Support $eq~~ feat: add support for $eq in LiveQuery Oct 5, 2021

sadakchap added 2 commits October 6, 2021 08:17

updated changelog.md

2b52e34

Merge branch 'master' into feat/sendLiveQueryEvent

3d06b2d

parse-community deleted a comment from parse-github-assistant bot Oct 6, 2021

mtrezza added 2 commits October 19, 2021 13:19

Merge branch 'master' into feat/sendLiveQueryEvent

d0554df

Update CHANGELOG.md

0287282

sadakchap and others added 4 commits November 16, 2021 19:10

added test case for new format query

f8b4f7b

Merge branch 'feat/sendLiveQueryEvent' of github.com:sadakchap/parse-…

adef3de

…server into feat/sendLiveQueryEvent

Merge branch 'alpha' of github.com:parse-community/parse-server into …

4beea42

…feat/sendLiveQueryEvent

Merge branch 'alpha' into feat/sendLiveQueryEvent

24e5964

sadakchap and others added 2 commits December 14, 2021 10:37

added more testcase for new query format

d35ce85

Merge branch 'alpha' into feat/sendLiveQueryEvent

825db53

sadakchap added 3 commits January 6, 2022 11:27

added testcase for array type

e864fd2

using objectId instead of id in testcases

8d5021f

Merge branch 'feat/sendLiveQueryEvent' of github.com:sadakchap/parse-…

70e6de8

…server into feat/sendLiveQueryEvent

mtrezza requested a review from a team January 6, 2022 13:39

Merge branch 'alpha' into feat/sendLiveQueryEvent

dd3ce1a

mtrezza reviewed Jan 6, 2022

View reviewed changes

mtrezza force-pushed the alpha branch from 59215e6 to e6d7d8f Compare May 1, 2022 02:29

mtrezza closed this Jul 21, 2024

parse-github-assistant bot changed the title ~~feat: add support for $eq in LiveQuery~~ feat: Add support for $eq in LiveQuery Jul 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add support for $eq in LiveQuery #7607

feat: Add support for $eq in LiveQuery #7607

sadakchap commented Oct 5, 2021 •

edited by mtrezza

Loading

parse-github-assistant bot commented Oct 5, 2021 •

edited

Loading

codecov bot commented Oct 5, 2021 •

edited

Loading

mtrezza commented Oct 13, 2021

sadakchap commented Oct 13, 2021

mtrezza commented Oct 13, 2021

sadakchap commented Oct 13, 2021

mtrezza commented Oct 13, 2021

mtrezza commented Oct 13, 2021

mtrezza commented Oct 30, 2021 •

edited

Loading

mtrezza commented Nov 17, 2021

mtrezza commented Jan 1, 2022

sadakchap commented Jan 6, 2022

mtrezza Jan 6, 2022 •

edited

Loading

sadakchap Jan 7, 2022

mtrezza Jan 8, 2022 •

edited

Loading

sadakchap Jan 9, 2022 •

edited

Loading

mtrezza Jan 12, 2022 •

edited

Loading

sadakchap Jan 19, 2022 •

edited

Loading

mtrezza Jan 19, 2022

cbaker6 commented Jul 19, 2024 •

edited

Loading

mtrezza commented Jul 21, 2024

parse-github-assistant bot commented Jul 21, 2024

feat: Add support for $eq in LiveQuery #7607

feat: Add support for $eq in LiveQuery #7607

Conversation

sadakchap commented Oct 5, 2021 • edited by mtrezza Loading

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

parse-github-assistant bot commented Oct 5, 2021 • edited Loading

Thanks for opening this pull request!

codecov bot commented Oct 5, 2021 • edited Loading

Codecov Report

mtrezza commented Oct 13, 2021

sadakchap commented Oct 13, 2021

mtrezza commented Oct 13, 2021

sadakchap commented Oct 13, 2021

mtrezza commented Oct 13, 2021

mtrezza commented Oct 13, 2021

mtrezza commented Oct 30, 2021 • edited Loading

mtrezza commented Nov 17, 2021

mtrezza commented Jan 1, 2022

sadakchap commented Jan 6, 2022

mtrezza Jan 6, 2022 • edited Loading

Choose a reason for hiding this comment

sadakchap Jan 7, 2022

Choose a reason for hiding this comment

mtrezza Jan 8, 2022 • edited Loading

Choose a reason for hiding this comment

sadakchap Jan 9, 2022 • edited Loading

Choose a reason for hiding this comment

mtrezza Jan 12, 2022 • edited Loading

Choose a reason for hiding this comment

sadakchap Jan 19, 2022 • edited Loading

Choose a reason for hiding this comment

mtrezza Jan 19, 2022

Choose a reason for hiding this comment

cbaker6 commented Jul 19, 2024 • edited Loading

mtrezza commented Jul 21, 2024

parse-github-assistant bot commented Jul 21, 2024

sadakchap commented Oct 5, 2021 •

edited by mtrezza

Loading

parse-github-assistant bot commented Oct 5, 2021 •

edited

Loading

codecov bot commented Oct 5, 2021 •

edited

Loading

mtrezza commented Oct 30, 2021 •

edited

Loading

mtrezza Jan 6, 2022 •

edited

Loading

mtrezza Jan 8, 2022 •

edited

Loading

sadakchap Jan 9, 2022 •

edited

Loading

mtrezza Jan 12, 2022 •

edited

Loading

sadakchap Jan 19, 2022 •

edited

Loading

cbaker6 commented Jul 19, 2024 •

edited

Loading