Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prototype pollution via Cloud Code Webhooks #8306

Merged

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Nov 9, 2022

Fixes security vulnerability GHSA-93vw-8fm5-p2jf

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 9, 2022

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 93.82% // Head: 84.09% // Decreases project coverage by -9.72% ⚠️

Coverage data is based on head (2748613) compared to base (8580a52).
Patch coverage: 95.61% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           release-4.x.x    #8306      +/-   ##
=================================================
- Coverage          93.82%   84.09%   -9.73%     
=================================================
  Files                170      170              
  Lines              12502    12556      +54     
=================================================
- Hits               11730    10559    -1171     
- Misses               772     1997    +1225     
Impacted Files Coverage Δ
src/Adapters/Auth/spotify.js 62.50% <60.00%> (-17.50%) ⬇️
src/Adapters/Auth/facebook.js 83.33% <80.00%> (-3.63%) ⬇️
src/Adapters/Files/GridFSBucketAdapter.js 93.43% <90.00%> (+13.92%) ⬆️
src/Controllers/DatabaseController.js 94.09% <100.00%> (-1.13%) ⬇️
src/LiveQuery/ParseCloudCodePublisher.js 100.00% <100.00%> (ø)
src/LiveQuery/ParseLiveQueryServer.js 95.18% <100.00%> (+0.14%) ⬆️
src/RestQuery.js 95.60% <100.00%> (+0.08%) ⬆️
src/RestWrite.js 93.80% <100.00%> (+0.04%) ⬆️
src/Routers/FilesRouter.js 91.60% <100.00%> (+4.53%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.42% <0.00%> (-93.52%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza mtrezza changed the title fix release 4.x.x p2jf fix: Prototype pollution via Cloud Code Webhooks Nov 9, 2022
@mtrezza mtrezza merged commit 6c63f04 into parse-community:release-4.x.x Nov 9, 2022
parseplatformorg pushed a commit that referenced this pull request Nov 9, 2022
## [4.10.20](4.10.19...4.10.20) (2022-11-09)

### Bug Fixes

* Prototype pollution via Cloud Code Webhooks; fixes security vulnerability [GHSA-93vw-8fm5-p2jf](GHSA-93vw-8fm5-p2jf) ([#8306](#8306)) ([6c63f04](6c63f04))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.10.20

@parseplatformorg parseplatformorg added the state:released-4.x.x Released as LTS version label Nov 9, 2022
@mtrezza mtrezza deleted the fix-release-4.x.x-p2jf branch November 10, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released-4.x.x Released as LTS version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants